From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Pavel Machek <pavel@ucw.cz>,
Douglas Anderson <dianders@chromium.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-leds@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/3] pwm/tracing: Also record trace events for failed apply calls
Date: Wed, 28 Sep 2022 14:50:33 +0200 [thread overview]
Message-ID: <YzRDGUxkah8Ridik@orome> (raw)
In-Reply-To: <20220916151506.298488-2-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
On Fri, Sep 16, 2022 at 05:15:05PM +0200, Uwe Kleine-König wrote:
> Record and report an error code for the events. This allows to report
> about failed calls without ambiguity and so gives a more complete
> picture.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pwm/core.c | 18 ++++++++----------
> include/trace/events/pwm.h | 20 ++++++++++----------
> 2 files changed, 18 insertions(+), 20 deletions(-)
Yeah, I like this one. Should make the traces much more useful in the
failure cases.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-28 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 15:15 [PATCH 1/3] pwm: Change prototype of .get_state() callback to return an error Uwe Kleine-König
2022-09-16 15:15 ` [PATCH 2/3] pwm/tracing: Also record trace events for failed apply calls Uwe Kleine-König
2022-09-28 12:50 ` Thierry Reding [this message]
2022-09-16 15:15 ` [PATCH 3/3] pwm: Handle .get_state() failures Uwe Kleine-König
2022-09-28 12:55 ` Thierry Reding
2022-09-28 12:49 ` [PATCH 1/3] pwm: Change prototype of .get_state() callback to return an error Thierry Reding
2022-09-29 6:55 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzRDGUxkah8Ridik@orome \
--to=thierry.reding@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=brgl@bgdev.pl \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=narmstrong@baylibre.com \
--cc=pavel@ucw.cz \
--cc=robert.foss@linaro.org \
--cc=rostedt@goodmis.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox