From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E41D188CCA for ; Mon, 25 Nov 2024 08:54:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732524883; cv=none; b=haeU4Bwomxyknd0cugYDMchLLz6TNDUpyFSZzyZhOSo2mJhtxbXzJE2LvoUYXxk3SYFUHPZxnaWbu50yaQJEyBFKX5lT6ZRVZJDIK5bdAW0NbYBJhYnT5Xfm3XHk5oRHJP3q0Y2OYcMK9fQQiIcanpWtpDaxhSiOfdDchyHAW8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732524883; c=relaxed/simple; bh=uZFCAWid8rhJHzelkWD3pFnre9T42ijXLP2LF1wPb9E=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nA1e4BxHEL0e78OfCrBLFkwtpKeHQiwK3tRsG+3b2Mv1FwGgsZwQdy1gwQsuDGniqhxN0xQ5FMM4/s0Gu1yAzFjVGX/vgGRXy4uxQg+tqYygxTSahwQsm3xQdo7Vh4G0GqnY99kbuZfKWNLo1aWiHWBGVRH0WKaG2wTIDp2be5Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TYtW/zP3; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TYtW/zP3" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5cf9ef18ae9so9853891a12.1 for ; Mon, 25 Nov 2024 00:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732524879; x=1733129679; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=mBZh/dlJgKLPhdmjnm36EVhHzC98YQaW9Lth/5vAKvc=; b=TYtW/zP3oxM1vFpM4KM8y6kvAht7l8o2L3yAU4ZwzteZAKmcbfAw8/WaoqTT3dTtiC cUftivx1BsOxrK0/JqNDCiJc366IyQbjOH4EI6rY7ZiYoX0xhGT2irkgFxMdJcmyAVel c/sjwVbyA4syCPaIRvjcuuZOi6VOS9DkpMBAOnNcGvcnPFrn9zNn6z1FYBNEfhObgdnJ rzU21xHVizGo+uiDf1yW/OlhTtMQ3w39bQL9SOVSncSGPWMPfFo43Nx2Q1m1p1HYCgIK 0jqtquHIKJIzjITbwZf4Aif6uFYkC8+8Fu3RC6hb9avaZ1Q0rGptY2c+B4ggNkffJ57D J84Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732524879; x=1733129679; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mBZh/dlJgKLPhdmjnm36EVhHzC98YQaW9Lth/5vAKvc=; b=Js7VG5G/MILW+AqPpqcx640Le1wU/1ttbj/95tQrCigU+atu3FVARH9PffUKIJqE01 FUxumci0SbL8Swvt4wMtTRF7QInFb9G+O9iqauEvDfM0NxHIIdjAHuyBOXEMAJ2LujpL l5UyJ/DWAXcPchqg4NQcf15GBFDEeeBQ15iL/AYQpUJN9w9Mj6TozVyoNMXApyAq9p34 wAY0XRbroCjTz0MEkLt69VCxZV7KqhJ3FAoIm/XhHBqUGj7nsLIWcfU0HT2B2i31+NHw Ue0lAiGmvJWj0U0lwJmjUw+qts+zmTc+e7/pxBQYWUmKuWjrbOHWyMTpkst9VOnzuaJc TSew== X-Forwarded-Encrypted: i=1; AJvYcCWKYsnb59qw41mrjUzPlth5TNjVmAG4UMVtQrUfsKjwnyhaUVR3759000EbX1lw13daYiIpezby+B8b@vger.kernel.org X-Gm-Message-State: AOJu0YwS6rQUYokcp5pAkQTrOKtFl3ffZm8z/Z/jAIjqaFB8hjlvYPrC hqPHTLMhyN7xSFmDs2RHpQQ6mCbNw4weRe3v45i8py4CdIkthwgWrZ7QaCUDR3Y= X-Gm-Gg: ASbGnctzzG5CTP+IwUjw2A/38b1AFJ1xgeb6hBx4Ce/u7Ux5ibNfZbJSXIjqcnwXHAW f4BbqjFCSda+hvE+FsDvCszspllJkyz65uggLb3y9S4KWRCW/bHS+4wPO29WDNtfN0HoAV7fpg3 BkRmhX2V7jo0rnM21I1AG7vv5YtCjdrMaUTe2ltAwczPdM1gJeQ4wDW5cEaJmcnMg/ib9APpzhV A7qVbKOut7LjjHi8CwGlmaACs3VaIAGxYEP4ZjQ9GyBQzFhEazDRTddmT7GCKlUOrnGc3bDA1K3 qnx29zwrgviatBgXxjVG X-Google-Smtp-Source: AGHT+IFNCFEK1ia8R/Vdi4LB9FLJuTXnKmbw4fkVMzsCxQu2qYrzuZQkQ2EAs+H3uMAiTz2NmcDbIA== X-Received: by 2002:a17:907:60ce:b0:aa4:e53f:5fbe with SMTP id a640c23a62f3a-aa509a1c2f9mr1339686366b.19.1732524879322; Mon, 25 Nov 2024 00:54:39 -0800 (PST) Received: from localhost (host-79-49-220-127.retail.telecomitalia.it. [79.49.220.127]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa51759732asm406733166b.14.2024.11.25.00.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 00:54:38 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 25 Nov 2024 09:55:11 +0100 To: Andrew Lunn Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v4 09/10] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5 Message-ID: References: <8deccbd7ab8915957342a097410473445987b044.1732444746.git.andrea.porta@suse.com> <9abb376c-3399-4c2c-8e7c-cea1184ea370@lunn.ch> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9abb376c-3399-4c2c-8e7c-cea1184ea370@lunn.ch> Hi Andrew, On 20:41 Sun 24 Nov , Andrew Lunn wrote: > On Sun, Nov 24, 2024 at 11:51:46AM +0100, Andrea della Porta wrote: > > The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz. > > Add clk_rp1_xosc node to provide that. > > I'm wondering if this is the correct place for this clock. From your > description, the bcm2712 itself does not provide the clock. There is a > crystal on the board. So the board provides the clock. What happens > when the RP1 is used on other boards? Also, does the RP1 need an > actual crystal, or can you feed it a clock? Often such inputs are > flexible, you can connect a crystal across two pins, or you can feed a > clock into one pin. AFAICT the only choice would be a crystal (I'll try to confirm that with Rpi folksi, just to be sure). In fact, I've expressed your same concern in the dicsussion that followed previous patchset revisions, and it seems that the preferred way is still to stick to the current hw: since the crystal is on the same board as bcm2712, it should not be described on the overaly. I think you're right though on moving the clock definition to the board dts. I'm still planning to define the clock in the rp1 overlay if any new PCI card will contain it in the future: after all it will not cause any clash with the clock defined in the board dts, which could be then removed gradually. Many thanks, Andrea > > If a crystal is the only choice, i would probably have it part of the > RP1 overlay. If a clock can be used, i would make it a board property. > > Andrew