From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: gregkh@linuxfoundation.org, linus.walleij@linaro.org,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, broonie@kernel.org,
pierre-louis.bossart@linux.dev, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 5/6] input: sparse-keymap: use devm_kmemdup_array()
Date: Tue, 26 Nov 2024 17:36:48 -0800 [thread overview]
Message-ID: <Z0Z3sBZsHz14ceiW@google.com> (raw)
In-Reply-To: <20241126172240.6044-6-raag.jadav@intel.com>
On Tue, Nov 26, 2024 at 10:52:39PM +0530, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/sparse-keymap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c
> index 25bf8be6e711..5ec3b9ebcac5 100644
> --- a/drivers/input/sparse-keymap.c
> +++ b/drivers/input/sparse-keymap.c
> @@ -176,8 +176,7 @@ int sparse_keymap_setup(struct input_dev *dev,
> for (e = keymap; e->type != KE_END; e++)
> map_size++;
>
> - map = devm_kmemdup(&dev->dev, keymap, map_size * sizeof(*map),
> - GFP_KERNEL);
> + map = devm_kmemdup_array(&dev->dev, keymap, map_size, sizeof(*map), GFP_KERNEL);
> if (!map)
> return -ENOMEM;
>
> --
> 2.35.3
>
--
Dmitry
next prev parent reply other threads:[~2024-11-27 1:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 17:22 [PATCH v2 0/6] Introduce devm_kmemdup_array() helper Raag Jadav
2024-11-26 17:22 ` [PATCH v2 1/6] devres: Introduce devm_kmemdup_array() Raag Jadav
2024-11-27 1:36 ` Dmitry Torokhov
2024-11-26 17:22 ` [PATCH v2 2/6] pinctrl: intel: copy communities using devm_kmemdup_array() Raag Jadav
2024-11-26 22:37 ` Andy Shevchenko
2024-11-26 17:22 ` [PATCH v2 3/6] pinctrl: tangier: use devm_kmemdup_array() Raag Jadav
2024-11-26 22:38 ` Andy Shevchenko
2024-11-26 17:22 ` [PATCH v2 4/6] pinctrl: pxa2xx: " Raag Jadav
2024-11-26 17:22 ` [PATCH v2 5/6] input: sparse-keymap: " Raag Jadav
2024-11-27 1:36 ` Dmitry Torokhov [this message]
2024-11-26 17:22 ` [PATCH v2 6/6] ASoC: Intel: avs: " Raag Jadav
2024-11-27 8:30 ` Amadeusz Sławiński
2024-11-26 22:40 ` [PATCH v2 0/6] Introduce devm_kmemdup_array() helper Andy Shevchenko
2024-11-27 1:37 ` Dmitry Torokhov
2024-11-29 10:17 ` Linus Walleij
2024-11-29 14:20 ` Andy Shevchenko
2024-12-07 14:46 ` Raag Jadav
2024-12-12 14:32 ` Andy Shevchenko
2024-12-12 14:39 ` Greg KH
2024-12-12 16:25 ` Andy Shevchenko
2025-01-16 14:50 ` Andy Shevchenko
2025-01-17 15:00 ` Raag Jadav
2025-01-20 17:07 ` Andy Shevchenko
2025-01-20 17:11 ` Andy Shevchenko
2025-01-21 6:05 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0Z3sBZsHz14ceiW@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).