[PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Raag Jadav]

This series introduces a more robust and cleaner devm_kmemdup_array()
helper and uses it across drivers.

v2: Use size_mul() for multiplication (Dmitry)
    Update commit message (Dmitry)

Raag Jadav (6):
  devres: Introduce devm_kmemdup_array()
  pinctrl: intel: copy communities using devm_kmemdup_array()
  pinctrl: tangier: use devm_kmemdup_array()
  pinctrl: pxa2xx: use devm_kmemdup_array()
  input: sparse-keymap: use devm_kmemdup_array()
  ASoC: Intel: avs: use devm_kmemdup_array()

 drivers/input/sparse-keymap.c           | 3 +--
 drivers/pinctrl/intel/pinctrl-intel.c   | 6 ++----
 drivers/pinctrl/intel/pinctrl-tangier.c | 5 ++---
 drivers/pinctrl/pxa/pinctrl-pxa2xx.c    | 8 ++++----
 include/linux/device.h                  | 5 +++++
 sound/soc/intel/avs/boards/da7219.c     | 3 ++-
 sound/soc/intel/avs/boards/es8336.c     | 3 ++-
 sound/soc/intel/avs/boards/nau8825.c    | 3 ++-
 sound/soc/intel/avs/boards/rt274.c      | 3 ++-
 sound/soc/intel/avs/boards/rt286.c      | 3 ++-
 sound/soc/intel/avs/boards/rt298.c      | 3 ++-
 sound/soc/intel/avs/boards/rt5663.c     | 3 ++-
 sound/soc/intel/avs/boards/rt5682.c     | 2 +-
 13 files changed, 29 insertions(+), 21 deletions(-)

-- 
2.35.3

[PATCH v2 1/6] devres: Introduce devm_kmemdup_array()

[Raag Jadav]

Introduce '_array' variant of devm_kmemdup() which is more robust and
consistent with alloc family of helpers.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 include/linux/device.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/device.h b/include/linux/device.h
index b4bde8d22697..c2032aab1586 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -358,6 +358,11 @@ char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp) __malloc;
 const char *devm_kstrdup_const(struct device *dev, const char *s, gfp_t gfp);
 void *devm_kmemdup(struct device *dev, const void *src, size_t len, gfp_t gfp)
 	__realloc_size(3);
+static inline void *devm_kmemdup_array(struct device *dev, const void *src,
+				       size_t n, size_t size, gfp_t flags)
+{
+	return devm_kmemdup(dev, src, size_mul(size, n), flags);
+}
 
 unsigned long devm_get_free_pages(struct device *dev,
 				  gfp_t gfp_mask, unsigned int order);
-- 
2.35.3

Re: [PATCH v2 1/6] devres: Introduce devm_kmemdup_array()

[Dmitry Torokhov]

On Tue, Nov 26, 2024 at 10:52:35PM +0530, Raag Jadav wrote:
> Introduce '_array' variant of devm_kmemdup() which is more robust and
> consistent with alloc family of helpers.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

Thank you for making the changes.

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

> ---
>  include/linux/device.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index b4bde8d22697..c2032aab1586 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -358,6 +358,11 @@ char *devm_kstrdup(struct device *dev, const char *s, gfp_t gfp) __malloc;
>  const char *devm_kstrdup_const(struct device *dev, const char *s, gfp_t gfp);
>  void *devm_kmemdup(struct device *dev, const void *src, size_t len, gfp_t gfp)
>  	__realloc_size(3);
> +static inline void *devm_kmemdup_array(struct device *dev, const void *src,
> +				       size_t n, size_t size, gfp_t flags)
> +{
> +	return devm_kmemdup(dev, src, size_mul(size, n), flags);
> +}
>  
>  unsigned long devm_get_free_pages(struct device *dev,
>  				  gfp_t gfp_mask, unsigned int order);
> -- 
> 2.35.3
> 

-- 
Dmitry

[PATCH v2 2/6] pinctrl: intel: copy communities using devm_kmemdup_array()

[Raag Jadav]

Copy communities using devm_kmemdup_array() instead of doing it manually.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/pinctrl/intel/pinctrl-intel.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 04b438f63ccb..e165bd5b5811 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1577,8 +1577,8 @@ int intel_pinctrl_probe(struct platform_device *pdev,
 	 * to the registers.
 	 */
 	pctrl->ncommunities = pctrl->soc->ncommunities;
-	pctrl->communities = devm_kcalloc(dev, pctrl->ncommunities,
-					  sizeof(*pctrl->communities), GFP_KERNEL);
+	pctrl->communities = devm_kmemdup_array(dev, pctrl->soc->communities, pctrl->ncommunities,
+						sizeof(*pctrl->communities), GFP_KERNEL);
 	if (!pctrl->communities)
 		return -ENOMEM;
 
@@ -1588,8 +1588,6 @@ int intel_pinctrl_probe(struct platform_device *pdev,
 		u32 offset;
 		u32 value;
 
-		*community = pctrl->soc->communities[i];
-
 		regs = devm_platform_ioremap_resource(pdev, community->barno);
 		if (IS_ERR(regs))
 			return PTR_ERR(regs);
-- 
2.35.3

Re: [PATCH v2 2/6] pinctrl: intel: copy communities using devm_kmemdup_array()

[Andy Shevchenko]

On Tue, Nov 26, 2024 at 10:52:36PM +0530, Raag Jadav wrote:
> Copy communities using devm_kmemdup_array() instead of doing it manually.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

[PATCH v2 3/6] pinctrl: tangier: use devm_kmemdup_array()

[Raag Jadav]

Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/pinctrl/intel/pinctrl-tangier.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
index 2cb0b4758269..305547100baa 100644
--- a/drivers/pinctrl/intel/pinctrl-tangier.c
+++ b/drivers/pinctrl/intel/pinctrl-tangier.c
@@ -524,7 +524,6 @@ static int tng_pinctrl_probe(struct platform_device *pdev,
 	struct device *dev = &pdev->dev;
 	struct tng_family *families;
 	struct tng_pinctrl *tp;
-	size_t families_len;
 	void __iomem *regs;
 	unsigned int i;
 
@@ -543,8 +542,8 @@ static int tng_pinctrl_probe(struct platform_device *pdev,
 	 * Make a copy of the families which we can use to hold pointers
 	 * to the registers.
 	 */
-	families_len = size_mul(sizeof(*families), tp->nfamilies);
-	families = devm_kmemdup(dev, tp->families, families_len, GFP_KERNEL);
+	families = devm_kmemdup_array(dev, tp->families, tp->nfamilies,
+				      sizeof(*families), GFP_KERNEL);
 	if (!families)
 		return -ENOMEM;
 
-- 
2.35.3

Re: [PATCH v2 3/6] pinctrl: tangier: use devm_kmemdup_array()

[Andy Shevchenko]

On Tue, Nov 26, 2024 at 10:52:37PM +0530, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

[PATCH v2 4/6] pinctrl: pxa2xx: use devm_kmemdup_array()

[Raag Jadav]

Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/pinctrl/pxa/pinctrl-pxa2xx.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
index 9e34b92ff5f2..9fd7a8fb2bc4 100644
--- a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
+++ b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
@@ -281,9 +281,8 @@ static int pxa2xx_build_functions(struct pxa_pinctrl *pctl)
 		for (df = pctl->ppins[i].functions; df->name; df++)
 			if (!pxa2xx_find_function(pctl, df->name, functions))
 				(functions + pctl->nfuncs++)->name = df->name;
-	pctl->functions = devm_kmemdup(pctl->dev, functions,
-				       pctl->nfuncs * sizeof(*functions),
-				       GFP_KERNEL);
+	pctl->functions = devm_kmemdup_array(pctl->dev, functions, pctl->nfuncs,
+					     sizeof(*functions), GFP_KERNEL);
 	if (!pctl->functions)
 		return -ENOMEM;
 
@@ -314,7 +313,8 @@ static int pxa2xx_build_groups(struct pxa_pinctrl *pctl)
 						pctl->ppins[j].pin.name;
 		func = pctl->functions + i;
 		func->ngroups = ngroups;
-		func->groups = devm_kmemdup(pctl->dev, gtmp, ngroups * sizeof(*gtmp), GFP_KERNEL);
+		func->groups = devm_kmemdup_array(pctl->dev, gtmp, ngroups,
+						  sizeof(*gtmp), GFP_KERNEL);
 		if (!func->groups)
 			return -ENOMEM;
 	}
-- 
2.35.3

[PATCH v2 5/6] input: sparse-keymap: use devm_kmemdup_array()

[Raag Jadav]

Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/input/sparse-keymap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c
index 25bf8be6e711..5ec3b9ebcac5 100644
--- a/drivers/input/sparse-keymap.c
+++ b/drivers/input/sparse-keymap.c
@@ -176,8 +176,7 @@ int sparse_keymap_setup(struct input_dev *dev,
 	for (e = keymap; e->type != KE_END; e++)
 		map_size++;
 
-	map = devm_kmemdup(&dev->dev, keymap, map_size * sizeof(*map),
-			   GFP_KERNEL);
+	map = devm_kmemdup_array(&dev->dev, keymap, map_size, sizeof(*map), GFP_KERNEL);
 	if (!map)
 		return -ENOMEM;
 
-- 
2.35.3

Re: [PATCH v2 5/6] input: sparse-keymap: use devm_kmemdup_array()

[Dmitry Torokhov]

On Tue, Nov 26, 2024 at 10:52:39PM +0530, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

> ---
>  drivers/input/sparse-keymap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/sparse-keymap.c b/drivers/input/sparse-keymap.c
> index 25bf8be6e711..5ec3b9ebcac5 100644
> --- a/drivers/input/sparse-keymap.c
> +++ b/drivers/input/sparse-keymap.c
> @@ -176,8 +176,7 @@ int sparse_keymap_setup(struct input_dev *dev,
>  	for (e = keymap; e->type != KE_END; e++)
>  		map_size++;
>  
> -	map = devm_kmemdup(&dev->dev, keymap, map_size * sizeof(*map),
> -			   GFP_KERNEL);
> +	map = devm_kmemdup_array(&dev->dev, keymap, map_size, sizeof(*map), GFP_KERNEL);
>  	if (!map)
>  		return -ENOMEM;
>  
> -- 
> 2.35.3
> 

-- 
Dmitry

[PATCH v2 6/6] ASoC: Intel: avs: use devm_kmemdup_array()

[Raag Jadav]

Convert to use devm_kmemdup_array() which is more robust.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/avs/boards/da7219.c  | 3 ++-
 sound/soc/intel/avs/boards/es8336.c  | 3 ++-
 sound/soc/intel/avs/boards/nau8825.c | 3 ++-
 sound/soc/intel/avs/boards/rt274.c   | 3 ++-
 sound/soc/intel/avs/boards/rt286.c   | 3 ++-
 sound/soc/intel/avs/boards/rt298.c   | 3 ++-
 sound/soc/intel/avs/boards/rt5663.c  | 3 ++-
 sound/soc/intel/avs/boards/rt5682.c  | 2 +-
 8 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/sound/soc/intel/avs/boards/da7219.c b/sound/soc/intel/avs/boards/da7219.c
index 80c0a1a95654..1b8f58b611a4 100644
--- a/sound/soc/intel/avs/boards/da7219.c
+++ b/sound/soc/intel/avs/boards/da7219.c
@@ -113,7 +113,8 @@ static int avs_da7219_codec_init(struct snd_soc_pcm_runtime *runtime)
 	}
 
 	num_pins = ARRAY_SIZE(card_headset_pins);
-	pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL);
+	pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins,
+				  sizeof(*pins), GFP_KERNEL);
 	if (!pins)
 		return -ENOMEM;
 
diff --git a/sound/soc/intel/avs/boards/es8336.c b/sound/soc/intel/avs/boards/es8336.c
index c8522e2430f8..8103e539e08a 100644
--- a/sound/soc/intel/avs/boards/es8336.c
+++ b/sound/soc/intel/avs/boards/es8336.c
@@ -109,7 +109,8 @@ static int avs_es8336_codec_init(struct snd_soc_pcm_runtime *runtime)
 	data = snd_soc_card_get_drvdata(card);
 	num_pins = ARRAY_SIZE(card_headset_pins);
 
-	pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL);
+	pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins,
+				  sizeof(*pins), GFP_KERNEL);
 	if (!pins)
 		return -ENOMEM;
 
diff --git a/sound/soc/intel/avs/boards/nau8825.c b/sound/soc/intel/avs/boards/nau8825.c
index 6ea9058fdb2a..0945a539b364 100644
--- a/sound/soc/intel/avs/boards/nau8825.c
+++ b/sound/soc/intel/avs/boards/nau8825.c
@@ -88,7 +88,8 @@ static int avs_nau8825_codec_init(struct snd_soc_pcm_runtime *runtime)
 	jack = snd_soc_card_get_drvdata(card);
 	num_pins = ARRAY_SIZE(card_headset_pins);
 
-	pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL);
+	pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins,
+				  sizeof(*pins), GFP_KERNEL);
 	if (!pins)
 		return -ENOMEM;
 
diff --git a/sound/soc/intel/avs/boards/rt274.c b/sound/soc/intel/avs/boards/rt274.c
index 9fcce86c6eb4..bdf36c7c744a 100644
--- a/sound/soc/intel/avs/boards/rt274.c
+++ b/sound/soc/intel/avs/boards/rt274.c
@@ -98,7 +98,8 @@ static int avs_rt274_codec_init(struct snd_soc_pcm_runtime *runtime)
 	jack = snd_soc_card_get_drvdata(card);
 	num_pins = ARRAY_SIZE(card_headset_pins);
 
-	pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL);
+	pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins,
+				  sizeof(*pins), GFP_KERNEL);
 	if (!pins)
 		return -ENOMEM;
 
diff --git a/sound/soc/intel/avs/boards/rt286.c b/sound/soc/intel/avs/boards/rt286.c
index f157f2d19efb..f94382389430 100644
--- a/sound/soc/intel/avs/boards/rt286.c
+++ b/sound/soc/intel/avs/boards/rt286.c
@@ -59,7 +59,8 @@ static int avs_rt286_codec_init(struct snd_soc_pcm_runtime *runtime)
 	jack = snd_soc_card_get_drvdata(card);
 	num_pins = ARRAY_SIZE(card_headset_pins);
 
-	pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL);
+	pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins,
+				  sizeof(*pins), GFP_KERNEL);
 	if (!pins)
 		return -ENOMEM;
 
diff --git a/sound/soc/intel/avs/boards/rt298.c b/sound/soc/intel/avs/boards/rt298.c
index 1e85242c8dd2..985bfa977edb 100644
--- a/sound/soc/intel/avs/boards/rt298.c
+++ b/sound/soc/intel/avs/boards/rt298.c
@@ -70,7 +70,8 @@ static int avs_rt298_codec_init(struct snd_soc_pcm_runtime *runtime)
 	jack = snd_soc_card_get_drvdata(card);
 	num_pins = ARRAY_SIZE(card_headset_pins);
 
-	pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL);
+	pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins,
+				  sizeof(*pins), GFP_KERNEL);
 	if (!pins)
 		return -ENOMEM;
 
diff --git a/sound/soc/intel/avs/boards/rt5663.c b/sound/soc/intel/avs/boards/rt5663.c
index 44f857e90969..fd8b0c915efa 100644
--- a/sound/soc/intel/avs/boards/rt5663.c
+++ b/sound/soc/intel/avs/boards/rt5663.c
@@ -65,7 +65,8 @@ static int avs_rt5663_codec_init(struct snd_soc_pcm_runtime *runtime)
 	jack = &priv->jack;
 	num_pins = ARRAY_SIZE(card_headset_pins);
 
-	pins = devm_kmemdup(card->dev, card_headset_pins, sizeof(*pins) * num_pins, GFP_KERNEL);
+	pins = devm_kmemdup_array(card->dev, card_headset_pins, num_pins,
+				  sizeof(*pins), GFP_KERNEL);
 	if (!pins)
 		return -ENOMEM;
 
diff --git a/sound/soc/intel/avs/boards/rt5682.c b/sound/soc/intel/avs/boards/rt5682.c
index 0dcc6392a0cc..6d7022707ca7 100644
--- a/sound/soc/intel/avs/boards/rt5682.c
+++ b/sound/soc/intel/avs/boards/rt5682.c
@@ -102,7 +102,7 @@ static int avs_rt5682_codec_init(struct snd_soc_pcm_runtime *runtime)
 	jack = snd_soc_card_get_drvdata(card);
 	num_pins = ARRAY_SIZE(card_jack_pins);
 
-	pins = devm_kmemdup(card->dev, card_jack_pins, sizeof(*pins) * num_pins, GFP_KERNEL);
+	pins = devm_kmemdup_array(card->dev, card_jack_pins, num_pins, sizeof(*pins), GFP_KERNEL);
 	if (!pins)
 		return -ENOMEM;
 
-- 
2.35.3

Re: [PATCH v2 6/6] ASoC: Intel: avs: use devm_kmemdup_array()

[Amadeusz Sławiński]

+Cezary

On 11/26/2024 6:22 PM, Raag Jadav wrote:
> Convert to use devm_kmemdup_array() which is more robust.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Acked-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Andy Shevchenko]

On Tue, Nov 26, 2024 at 10:52:34PM +0530, Raag Jadav wrote:
> This series introduces a more robust and cleaner devm_kmemdup_array()
> helper and uses it across drivers.


I believe the best is to route this via Intel pin control tree, but we need
an Ack from Greg and Dmitry. Or share your vision on this.

> Raag Jadav (6):
>   devres: Introduce devm_kmemdup_array()
>   pinctrl: intel: copy communities using devm_kmemdup_array()
>   pinctrl: tangier: use devm_kmemdup_array()
>   pinctrl: pxa2xx: use devm_kmemdup_array()
>   input: sparse-keymap: use devm_kmemdup_array()
>   ASoC: Intel: avs: use devm_kmemdup_array()
> 
>  drivers/input/sparse-keymap.c           | 3 +--
>  drivers/pinctrl/intel/pinctrl-intel.c   | 6 ++----
>  drivers/pinctrl/intel/pinctrl-tangier.c | 5 ++---
>  drivers/pinctrl/pxa/pinctrl-pxa2xx.c    | 8 ++++----
>  include/linux/device.h                  | 5 +++++
>  sound/soc/intel/avs/boards/da7219.c     | 3 ++-
>  sound/soc/intel/avs/boards/es8336.c     | 3 ++-
>  sound/soc/intel/avs/boards/nau8825.c    | 3 ++-
>  sound/soc/intel/avs/boards/rt274.c      | 3 ++-
>  sound/soc/intel/avs/boards/rt286.c      | 3 ++-
>  sound/soc/intel/avs/boards/rt298.c      | 3 ++-
>  sound/soc/intel/avs/boards/rt5663.c     | 3 ++-
>  sound/soc/intel/avs/boards/rt5682.c     | 2 +-
>  13 files changed, 29 insertions(+), 21 deletions(-)

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Dmitry Torokhov]

On Wed, Nov 27, 2024 at 12:40:18AM +0200, Andy Shevchenko wrote:
> On Tue, Nov 26, 2024 at 10:52:34PM +0530, Raag Jadav wrote:
> > This series introduces a more robust and cleaner devm_kmemdup_array()
> > helper and uses it across drivers.
> 
> 
> I believe the best is to route this via Intel pin control tree, but we need
> an Ack from Greg and Dmitry. Or share your vision on this.

Sounds good to me.

Thanks.

-- 
Dmitry

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Linus Walleij]

On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:

> This series introduces a more robust and cleaner devm_kmemdup_array()
> helper and uses it across drivers.

For the series:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

It seems like Andy will push it to me which is excellent.

Yours,
Linus Walleij

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Andy Shevchenko]

On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> 
> > This series introduces a more robust and cleaner devm_kmemdup_array()
> > helper and uses it across drivers.
> 
> For the series:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> It seems like Andy will push it to me which is excellent.

Yep, that's the plan after we get all necessary ACKs.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Raag Jadav]

On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > 
> > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > helper and uses it across drivers.
> > 
> > For the series:
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > 
> > It seems like Andy will push it to me which is excellent.
> 
> Yep, that's the plan after we get all necessary ACKs.

Greg, anything I can do to move this forward?

Raag

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Andy Shevchenko]

On Sat, Dec 07, 2024 at 04:46:18PM +0200, Raag Jadav wrote:
> On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> > On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > > 
> > > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > > helper and uses it across drivers.
> > > 
> > > For the series:
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > 
> > > It seems like Andy will push it to me which is excellent.
> > 
> > Yep, that's the plan after we get all necessary ACKs.
> 
> Greg, anything I can do to move this forward?

Greg, is it possible to give your Ack or comment or guidance of the preferences
with the first patch?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Greg KH]

On Thu, Dec 12, 2024 at 04:32:48PM +0200, Andy Shevchenko wrote:
> On Sat, Dec 07, 2024 at 04:46:18PM +0200, Raag Jadav wrote:
> > On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> > > On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > > > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > > > 
> > > > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > > > helper and uses it across drivers.
> > > > 
> > > > For the series:
> > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > > 
> > > > It seems like Andy will push it to me which is excellent.
> > > 
> > > Yep, that's the plan after we get all necessary ACKs.
> > 
> > Greg, anything I can do to move this forward?
> 
> Greg, is it possible to give your Ack or comment or guidance of the preferences
> with the first patch?

$ mdfrm -c ~/mail/todo/
2293 messages in /home/gregkh/mail/todo/

Please be patient.

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Andy Shevchenko]

On Thu, Dec 12, 2024 at 03:39:57PM +0100, Greg KH wrote:
> On Thu, Dec 12, 2024 at 04:32:48PM +0200, Andy Shevchenko wrote:
> > On Sat, Dec 07, 2024 at 04:46:18PM +0200, Raag Jadav wrote:
> > > On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> > > > On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > > > > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > > > > 
> > > > > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > > > > helper and uses it across drivers.
> > > > > 
> > > > > For the series:
> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > > > 
> > > > > It seems like Andy will push it to me which is excellent.
> > > > 
> > > > Yep, that's the plan after we get all necessary ACKs.
> > > 
> > > Greg, anything I can do to move this forward?
> > 
> > Greg, is it possible to give your Ack or comment or guidance of the preferences
> > with the first patch?
> 
> $ mdfrm -c ~/mail/todo/
> 2293 messages in /home/gregkh/mail/todo/

Oh my...

> Please be patient.

Sure!


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Andy Shevchenko]

On Thu, Dec 12, 2024 at 06:25:16PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 12, 2024 at 03:39:57PM +0100, Greg KH wrote:
> > On Thu, Dec 12, 2024 at 04:32:48PM +0200, Andy Shevchenko wrote:
> > > On Sat, Dec 07, 2024 at 04:46:18PM +0200, Raag Jadav wrote:
> > > > On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> > > > > On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > > > > > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > > > > > 
> > > > > > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > > > > > helper and uses it across drivers.
> > > > > > 
> > > > > > For the series:
> > > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > > > > 
> > > > > > It seems like Andy will push it to me which is excellent.
> > > > > 
> > > > > Yep, that's the plan after we get all necessary ACKs.
> > > > 
> > > > Greg, anything I can do to move this forward?
> > > 
> > > Greg, is it possible to give your Ack or comment or guidance of the preferences
> > > with the first patch?
> > 
> > $ mdfrm -c ~/mail/todo/
> > 2293 messages in /home/gregkh/mail/todo/
> 
> Oh my...
> 
> > Please be patient.
> 
> Sure!

Raaj, care to send a v3 after merge window closes?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Raag Jadav]

On Thu, Jan 16, 2025 at 04:50:45PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 12, 2024 at 06:25:16PM +0200, Andy Shevchenko wrote:
> > On Thu, Dec 12, 2024 at 03:39:57PM +0100, Greg KH wrote:
> > > On Thu, Dec 12, 2024 at 04:32:48PM +0200, Andy Shevchenko wrote:
> > > > On Sat, Dec 07, 2024 at 04:46:18PM +0200, Raag Jadav wrote:
> > > > > On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> > > > > > On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > > > > > > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > > > > > > 
> > > > > > > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > > > > > > helper and uses it across drivers.
> > > > > > > 
> > > > > > > For the series:
> > > > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > > > > > 
> > > > > > > It seems like Andy will push it to me which is excellent.
> > > > > > 
> > > > > > Yep, that's the plan after we get all necessary ACKs.
> > > > > 
> > > > > Greg, anything I can do to move this forward?
> > > > 
> > > > Greg, is it possible to give your Ack or comment or guidance of the preferences
> > > > with the first patch?
> > > 
> > > $ mdfrm -c ~/mail/todo/
> > > 2293 messages in /home/gregkh/mail/todo/
> > 
> > Oh my...
> > 
> > > Please be patient.
> > 
> > Sure!
> 
> Raaj, care to send a v3 after merge window closes?

Sure, and perhaps add a few more users which I found with my improved
grepping skills.

Raag

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Andy Shevchenko]

On Fri, Jan 17, 2025 at 05:00:34PM +0200, Raag Jadav wrote:
> On Thu, Jan 16, 2025 at 04:50:45PM +0200, Andy Shevchenko wrote:
> > On Thu, Dec 12, 2024 at 06:25:16PM +0200, Andy Shevchenko wrote:
> > > On Thu, Dec 12, 2024 at 03:39:57PM +0100, Greg KH wrote:
> > > > On Thu, Dec 12, 2024 at 04:32:48PM +0200, Andy Shevchenko wrote:
> > > > > On Sat, Dec 07, 2024 at 04:46:18PM +0200, Raag Jadav wrote:
> > > > > > On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> > > > > > > On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > > > > > > > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > > > > > > > 
> > > > > > > > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > > > > > > > helper and uses it across drivers.
> > > > > > > > 
> > > > > > > > For the series:
> > > > > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > > > > > > 
> > > > > > > > It seems like Andy will push it to me which is excellent.
> > > > > > > 
> > > > > > > Yep, that's the plan after we get all necessary ACKs.
> > > > > > 
> > > > > > Greg, anything I can do to move this forward?
> > > > > 
> > > > > Greg, is it possible to give your Ack or comment or guidance of the preferences
> > > > > with the first patch?
> > > > 
> > > > $ mdfrm -c ~/mail/todo/
> > > > 2293 messages in /home/gregkh/mail/todo/
> > > 
> > > Oh my...
> > > 
> > > > Please be patient.
> > > 
> > > Sure!
> > 
> > Raaj, care to send a v3 after merge window closes?
> 
> Sure, and perhaps add a few more users which I found with my improved
> grepping skills.

Okay, thanks! I will drop myself from this thread then. Waiting for v3...

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Andy Shevchenko]

On Mon, Jan 20, 2025 at 07:07:33PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 17, 2025 at 05:00:34PM +0200, Raag Jadav wrote:
> > On Thu, Jan 16, 2025 at 04:50:45PM +0200, Andy Shevchenko wrote:
> > > On Thu, Dec 12, 2024 at 06:25:16PM +0200, Andy Shevchenko wrote:
> > > > On Thu, Dec 12, 2024 at 03:39:57PM +0100, Greg KH wrote:
> > > > > On Thu, Dec 12, 2024 at 04:32:48PM +0200, Andy Shevchenko wrote:
> > > > > > On Sat, Dec 07, 2024 at 04:46:18PM +0200, Raag Jadav wrote:
> > > > > > > On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> > > > > > > > On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > > > > > > > > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > > > > > > > > 
> > > > > > > > > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > > > > > > > > helper and uses it across drivers.
> > > > > > > > > 
> > > > > > > > > For the series:
> > > > > > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > > > > > > > 
> > > > > > > > > It seems like Andy will push it to me which is excellent.
> > > > > > > > 
> > > > > > > > Yep, that's the plan after we get all necessary ACKs.
> > > > > > > 
> > > > > > > Greg, anything I can do to move this forward?
> > > > > > 
> > > > > > Greg, is it possible to give your Ack or comment or guidance of the preferences
> > > > > > with the first patch?
> > > > > 
> > > > > $ mdfrm -c ~/mail/todo/
> > > > > 2293 messages in /home/gregkh/mail/todo/
> > > > 
> > > > Oh my...
> > > > 
> > > > > Please be patient.
> > > > 
> > > > Sure!
> > > 
> > > Raaj, care to send a v3 after merge window closes?
> > 
> > Sure, and perhaps add a few more users which I found with my improved
> > grepping skills.
> 
> Okay, thanks! I will drop myself from this thread then. Waiting for v3...

One more thing, can you embed the following into your series?

20241203195340.855879-1-andriy.shevchenko@linux.intel.com

It would be easier to handle and avoid conflicts.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/6] Introduce devm_kmemdup_array() helper

[Raag Jadav]

On Mon, Jan 20, 2025 at 07:11:22PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 20, 2025 at 07:07:33PM +0200, Andy Shevchenko wrote:
> > On Fri, Jan 17, 2025 at 05:00:34PM +0200, Raag Jadav wrote:
> > > On Thu, Jan 16, 2025 at 04:50:45PM +0200, Andy Shevchenko wrote:
> > > > On Thu, Dec 12, 2024 at 06:25:16PM +0200, Andy Shevchenko wrote:
> > > > > On Thu, Dec 12, 2024 at 03:39:57PM +0100, Greg KH wrote:
> > > > > > On Thu, Dec 12, 2024 at 04:32:48PM +0200, Andy Shevchenko wrote:
> > > > > > > On Sat, Dec 07, 2024 at 04:46:18PM +0200, Raag Jadav wrote:
> > > > > > > > On Fri, Nov 29, 2024 at 04:20:14PM +0200, Andy Shevchenko wrote:
> > > > > > > > > On Fri, Nov 29, 2024 at 11:17:02AM +0100, Linus Walleij wrote:
> > > > > > > > > > On Tue, Nov 26, 2024 at 6:22 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > > > > > > > > > 
> > > > > > > > > > > This series introduces a more robust and cleaner devm_kmemdup_array()
> > > > > > > > > > > helper and uses it across drivers.
> > > > > > > > > > 
> > > > > > > > > > For the series:
> > > > > > > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > > > > > > > > > 
> > > > > > > > > > It seems like Andy will push it to me which is excellent.
> > > > > > > > > 
> > > > > > > > > Yep, that's the plan after we get all necessary ACKs.
> > > > > > > > 
> > > > > > > > Greg, anything I can do to move this forward?
> > > > > > > 
> > > > > > > Greg, is it possible to give your Ack or comment or guidance of the preferences
> > > > > > > with the first patch?
> > > > > > 
> > > > > > $ mdfrm -c ~/mail/todo/
> > > > > > 2293 messages in /home/gregkh/mail/todo/
> > > > > 
> > > > > Oh my...
> > > > > 
> > > > > > Please be patient.
> > > > > 
> > > > > Sure!
> > > > 
> > > > Raaj, care to send a v3 after merge window closes?
> > > 
> > > Sure, and perhaps add a few more users which I found with my improved
> > > grepping skills.
> > 
> > Okay, thanks! I will drop myself from this thread then. Waiting for v3...
> 
> One more thing, can you embed the following into your series?
> 
> 20241203195340.855879-1-andriy.shevchenko@linux.intel.com
> 
> It would be easier to handle and avoid conflicts.

Sure.

Raag