Re: [PATCH 01/19] powerpc: Generalize MPC831x platform support

["J. Neuschäfer" <j.ne@posteo.net>]

On Mon, Jan 06, 2025 at 02:50:31PM +0100, Christophe Leroy wrote:
> 
> 
> Le 02/01/2025 à 19:31, J. Neuschäfer via B4 Relay a écrit :
> > [Vous ne recevez pas souvent de courriers de devnull+j.ne.posteo.net@kernel.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> > 
> > From: "J. Neuschäfer" <j.ne@posteo.net>
> > 
> > The Reference Design Boards (RDB) don't have the same relevance they had
> > then the MPC831x platform was new; if any work is done today, then
> > likely based on used production boards, which are more readily available
> > than NXP's discontinued devboards.
> > 
> > To further reduce the focus on RDBs, add DT compatible strings for all
> > four MPC8314/5 variants.
> 
> Seems like this patch does more than adding DT compatible strings.

I'll move the addition of DT compatibles to a new patch.

> 
> > 
> > Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> > ---
[...]
> > diff --git a/arch/powerpc/platforms/83xx/Kconfig b/arch/powerpc/platforms/83xx/Kconfig
> > index d355ad40995fdc0fc3b4355126c65c761c21c296..944ec44a1fa6044b03ac71c295e891cd411ce444 100644
> > --- a/arch/powerpc/platforms/83xx/Kconfig
> > +++ b/arch/powerpc/platforms/83xx/Kconfig
> > @@ -18,12 +18,12 @@ config MPC830x_RDB
> >          help
> >            This option enables support for the MPC8308 RDB and MPC8308 P1M boards.
> > 
> > -config MPC831x_RDB
> > -       bool "Freescale MPC831x RDB"
> > +config MPC831x
> 
> That looks confusing. We already have CONFIG_PPC_MPC831x

Fair enough. How about CONFIG_MPC831x_BOARDS?

> 
> > +       bool "Freescale MPC831x boards"
> >          select DEFAULT_UIMAGE
> >          select PPC_MPC831x
> >          help
> > -         This option enables support for the MPC8313 RDB and MPC8315 RDB boards.
> > +         This option enables support for all MPC831x-based boards.
> > 
> >   config MPC832x_RDB
> >          bool "Freescale MPC832x RDB"
> > diff --git a/arch/powerpc/platforms/83xx/Makefile b/arch/powerpc/platforms/83xx/Makefile
> > index 6fc3dba943dade4f63da090b520b0c35bb46a091..92fb0b34913e1113d3e6eac49acbb1c32fb06ab7 100644
> > --- a/arch/powerpc/platforms/83xx/Makefile
> > +++ b/arch/powerpc/platforms/83xx/Makefile
> > @@ -6,7 +6,7 @@ obj-y                           := misc.o
> >   obj-$(CONFIG_SUSPEND)          += suspend.o suspend-asm.o
> >   obj-$(CONFIG_MCU_MPC8349EMITX) += mcu_mpc8349emitx.o
> >   obj-$(CONFIG_MPC830x_RDB)      += mpc830x_rdb.o
> > -obj-$(CONFIG_MPC831x_RDB)      += mpc831x_rdb.o
> > +obj-$(CONFIG_MPC831x)          += mpc831x.o
> >   obj-$(CONFIG_MPC832x_RDB)      += mpc832x_rdb.o
> >   obj-$(CONFIG_MPC834x_ITX)      += mpc834x_itx.o
> >   obj-$(CONFIG_MPC836x_RDK)      += mpc836x_rdk.o
> > diff --git a/arch/powerpc/platforms/83xx/mpc831x_rdb.c b/arch/powerpc/platforms/83xx/mpc831x.c
> > similarity index 65%
> > rename from arch/powerpc/platforms/83xx/mpc831x_rdb.c
> > rename to arch/powerpc/platforms/83xx/mpc831x.c
> > index 5c39966762e4264d2ef91b2c4ef75fdf2c2c5d65..7250fc11c7ee80b266f39d0b3aebb0deb777c129 100644
> > --- a/arch/powerpc/platforms/83xx/mpc831x_rdb.c
> > +++ b/arch/powerpc/platforms/83xx/mpc831x.c
> > @@ -1,8 +1,8 @@
> >   // SPDX-License-Identifier: GPL-2.0-or-later
> >   /*
> > - * arch/powerpc/platforms/83xx/mpc831x_rdb.c
> > + * arch/powerpc/platforms/83xx/mpc831x.c
> 
> Please remove the file name from the file.

Will do.

> >    *
> > - * Description: MPC831x RDB board specific routines.
> > + * Description: MPC831x board specific routines.
> 
> s/board/boards ?

No, the "board" in "board specific" doesn't get pluralized when there
are multiple boards. How about the following?

      * Description: MPC831x specific routines.



Best regards,
J. Neuschäfer