From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46D42213E7B for ; Fri, 10 Jan 2025 16:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.67.36.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736526515; cv=none; b=K3WNW4/2u8pTVMNJBXumjgEbOr+614Ai1L4zE7vvh2dU6bkv9rPrPRCURSDaEyzXtZhRSggu8eyJA4fJKJh1NqU9Bg9lPzTfnulK26BMgRFCk9FTISG1BgDs6k0O8iHbffwcZ07rmBoxhDq78AI/MZD/ub31wIvJdAbUwUN4MCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736526515; c=relaxed/simple; bh=OWts1cTfEcqvunfpgiC/6+tnJNk+ma0tlrEZc31g47A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XayBlhub7klD4wonpcg48ExSne3gKhkmJr0EutcYymEBVWB7BElP3M6r9zD0LudSFTu9HHScNhYLavBup2s3aiNMuUtIpHP7XasfSWwmcr0Wwm8ZKqtdjokcQST3+PR4f1JUcmcx8Cs9bTdkOCDniFOY7ooZHwiyN1iHW0Ns/SQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net; spf=pass smtp.mailfrom=posteo.net; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b=WdpPGeH9; arc=none smtp.client-ip=185.67.36.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=posteo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=posteo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=posteo.net header.i=@posteo.net header.b="WdpPGeH9" Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A55BD240105 for ; Fri, 10 Jan 2025 17:28:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1736526512; bh=OWts1cTfEcqvunfpgiC/6+tnJNk+ma0tlrEZc31g47A=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=WdpPGeH9npb33QnUOY81diFY2jW+kyyugTdHJvEGF9G1zEGqfaHygQjPTDm7UKCk/ XODtKbK5/zkMQq0bnsn88xVPtv5G3mTxL+2zuIPAhUXocsyDWkeB4iJMKmqM/YPcfq 0JYd6Jdo/D7qUbErY0X9l0skU86O9QV+pmS2T0MklAIlRGrdZION88sxqbUUTKi7xo hUrQu9IbnbIN9cpZScAEgnqBVP4LNiQCvlggmDSpj6k3IqcogSH9ZwG8hLQ+ugbt4/ dzIAqPYeUQAazbBgdAE/RvL8TIzZG14jcE8aQJmJ+0C98uUDVKnoIXp+cTT49Cn2NF 1nD3E2eP4C0eg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YV6Xb2P9Xz6tw1; Fri, 10 Jan 2025 17:28:31 +0100 (CET) Date: Fri, 10 Jan 2025 16:28:31 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Krzysztof Kozlowski Cc: j.ne@posteo.net, Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Frank Li , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 10/19] powerpc: dts: Add MPC8314E devicetree Message-ID: References: <20250102-mpc83xx-v1-0-86f78ba2a7af@posteo.net> <20250102-mpc83xx-v1-10-86f78ba2a7af@posteo.net> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jan 10, 2025 at 04:21:58PM +0100, Krzysztof Kozlowski wrote: > On 02/01/2025 19:31, J. Neuschäfer via B4 Relay wrote: > > From: "J. Neuschäfer" > > > > The MPC8314E is a variant of the MPC8315E without SATA controllers. > > > > Signed-off-by: J. Neuschäfer > > --- > > arch/powerpc/boot/dts/mpc8314e.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/powerpc/boot/dts/mpc8314e.dtsi b/arch/powerpc/boot/dts/mpc8314e.dtsi > > new file mode 100644 > > index 0000000000000000000000000000000000000000..65a96a485dded5d4918d96b38778399d2f348190 > > --- /dev/null > > +++ b/arch/powerpc/boot/dts/mpc8314e.dtsi > > @@ -0,0 +1,7 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > +// Copyright 2024 J. Neuschäfer > > +#include "mpc8315e.dtsi" > > + > > +/* MPC8314E does not support SATA */ > > +/delete-node/ &sata0; > > +/delete-node/ &sata1; > > > You should not delete nodes. That's not really maintainable code. Either > this is in base DTSI or it does not. If it does exist, then this delete > is incorrect. > > If it does not delete, you are not supposed to include other SoC/device > which is not the subset of this one, so your includes are not correct. With that in mind, I think it makes sense to structure these (up to) four devices the other way around: - MPC8314 as the base, because it has the least features - MPC8314E, MPC8315E, and the currently unused MPC8315 based on MPC8314 I'll do that. Best regards, J. Neuschäfer