From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6722A26BD9A for ; Tue, 11 Feb 2025 13:45:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739281558; cv=none; b=rB5Wk7SckjKDTV3lz6LS8/OpapfbNhcUU5KY7rxFbYq+GessEHj5XdQRpXRbRfQvZQMVE2HhE4D1p2XyfyyQ0AeI24eQiYIpqZD3gfKkliIjeK8BBTprIZQUoW3Co1+s1OpmTF3z+FGGCLvHf25IXqtMOz09AP7z+l1Vx7hBV3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739281558; c=relaxed/simple; bh=5Ls6ehrFuNfDtokxDzaR2J5p2+P5rZ6x9GJCMdIdOXU=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CJBzBVPOP3ig3gTuAm3MooRz3C7zX0LbeIHGXFUeRxJl6+TpFbnMTXa2mt8PFWs1AqQ/pKBprnpMiDOmxOaYpZeumX6GZ6iJnKx7ezJIlunqzIYDCElTqWlVJ/YlQDnOWiZ1rwt3xauaEKvrdYuJAjs7eaR45oQZsmyHuNPEZy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=A2DLbn6D; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="A2DLbn6D" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ab7d583d2afso236292966b.0 for ; Tue, 11 Feb 2025 05:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1739281555; x=1739886355; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=RkP+VyXyd2LDTq1dE/e/+i0gFwY3obdySQr3wdtK8hs=; b=A2DLbn6D3yiNZvfFC/1uJgUHenzjcoi+hkZfcq814JXPSlSOlPs/Qet+GZmi+76MTV Lu5xGnRkPKsiG0VsG7jiM6C/1ChBjq3mvshyHDa83MCd4FQ+B05gIaSQ1p7K0uM+ltxN NNuARlr/LY7RPhAcItmlQxmAp8qXpsVH5kEHTrBzBXGqMxkL/NwWNBz7p2bWAuC9iciq fK8W/yz6buao4PKvhXcSHihHdoLjidcAndLA7Xxw0tTAt2hFq6Oyl+UPDmJwF9FrLw2c ueckiz/HoRw6zAoLvKxraQp4js/qXehAsdcQyn1D4JMR8LshNiT0VzQsUKV0Lr2ONejI vY/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739281555; x=1739886355; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RkP+VyXyd2LDTq1dE/e/+i0gFwY3obdySQr3wdtK8hs=; b=du5w549CXNhGVUYpnagkX67HtpQMwT0Hkbmn+wI4CYqiDZE5SrB4KP626rNTkLX7N7 tK1rY6VYp7Wc2nr5GbkxTdyide/6XIf+94t4IYng01Z04P9llSfA7mocqpjK5qrUkMJ2 RaNw/gIhsQwbzA4wHGSm4OcDiIWuwh8hdMHdF4FTY2fRwr8+VNU492K2PHsGEsMIdisg h2U4jtbNYBZoeYYLSXZdKXFlQgzPQ8RNf/G0zYtkgc94gxBsmzFR54woANgYwEPAD0oD gdiw57vVcDifxdeng37xdMGXYG8PICHVTgvHYy3fALCWM7IwzhRAAl5c4poxh41yH8L7 LqQQ== X-Forwarded-Encrypted: i=1; AJvYcCWh/ob87M9T2mgLMVghGkuUGBJJWVqlBLJHdBE6DJD9qNvYargt3gbVrJFVZnN5tS0XDOlBMRlkzZ77@vger.kernel.org X-Gm-Message-State: AOJu0YyHEx4QkvQUClTIdJnUDlfJYlD8ZH3yqOWIfhUWvr36W7QkgGdg Q5EqALHjWeGUeD4wQYs6MX4GvX5jtRS0lRmCJ5/gUmvQ7+jpsoc/iC4nPLSacz4= X-Gm-Gg: ASbGnctRPpH5DahHcJsqOYgKoeIaxuISbxnZM4bSeKoPBo+/d8038ctrtjLOGVtjLkt DLCDVqRSiZJIJz7Mo2+QGRJ4tpwlFWzPMTN7dsmFs8cJmpXxoyFAlVUO57mNoWn7kgUxgWiE8Z8 r1usQa4+8g7WGKrudeXAaVP7t8iEIVzDadBU9BlhDFXk+eH539GSvumUzeRfTFTzubGPyustlPi vdrZk2rjwcaHwoSZbs3tNHgVjhJXzEyVRZMDK3+3iPREP7uKAqX48kk8R1luLcFXJB6gABxwnhJ TSf4NoNyrxzC8694CZTfQoihNSyDZ7Hx5j50SiGBjnfQjB8K/3L/CPIstPs= X-Google-Smtp-Source: AGHT+IG51KR7uQClui5T80GFu03wGjZtCbiNcOn2c2quAcoJxfpyu2MvcnnQYDV8Nd/6UX7Ol8OjhA== X-Received: by 2002:a17:907:6ea0:b0:ab7:c11:a980 with SMTP id a640c23a62f3a-ab7db544773mr282512766b.17.1739281554584; Tue, 11 Feb 2025 05:45:54 -0800 (PST) Received: from localhost (host-79-41-239-37.retail.telecomitalia.it. [79.41.239.37]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7b43ee08asm522714066b.88.2025.02.11.05.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 05:45:54 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 11 Feb 2025 14:46:53 +0100 To: Stefan Wahren Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v7 06/11] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Message-ID: References: <8e2b0e05-cd60-4b79-8763-005c3f72a64d@gmx.net> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e2b0e05-cd60-4b79-8763-005c3f72a64d@gmx.net> Hi Stefan, On 15:36 Sat 08 Feb , Stefan Wahren wrote: > Hi Andrea, > > Am 07.02.25 um 22:31 schrieb Andrea della Porta: > > The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl. > > Add minimum support for the gpio only portion. The driver is in > > pinctrl folder since upcoming patches will add the pinmux/pinctrl > > support where the gpio part can be seen as an addition. > > > > Signed-off-by: Andrea della Porta > > Reviewed-by: Linus Walleij > > Reviewed-by: Stefan Wahren > > --- > > MAINTAINERS | 1 + > > drivers/pinctrl/Kconfig | 11 + > > drivers/pinctrl/Makefile | 1 + > > drivers/pinctrl/pinctrl-rp1.c | 789 ++++++++++++++++++++++++++++++++++ > > 4 files changed, 802 insertions(+) > > create mode 100644 drivers/pinctrl/pinctrl-rp1.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index a4a9555c07c5..f2ba6f565d30 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -19756,6 +19756,7 @@ F: Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > F: Documentation/devicetree/bindings/pci/pci-ep-bus.yaml > > F: Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml > > F: drivers/clk/clk-rp1.c > > +F: drivers/pinctrl/pinctrl-rp1.c > > F: include/dt-bindings/clock/rp1.h > > F: include/dt-bindings/misc/rp1.h > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > index 95a8e2b9a614..53b265cabc26 100644 > > --- a/drivers/pinctrl/Kconfig > > +++ b/drivers/pinctrl/Kconfig > > @@ -612,6 +612,17 @@ config PINCTRL_MLXBF3 > > each pin. This driver can also be built as a module called > > pinctrl-mlxbf3. > > > > +config PINCTRL_RP1 > > + tristate "Pinctrl driver for RP1" > > + depends on MISC_RP1 > > + default MISC_RP1 > > + select PINMUX > > + select PINCONF > > + select GENERIC_PINCONF > > + help > > + Enable the gpio and pinctrl/mux driver for RaspberryPi RP1 > > + multi function device. > > + > > source "drivers/pinctrl/actions/Kconfig" > > source "drivers/pinctrl/aspeed/Kconfig" > > source "drivers/pinctrl/bcm/Kconfig" > > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > > index fba1c56624c0..6fb77de58545 100644 > > --- a/drivers/pinctrl/Makefile > > +++ b/drivers/pinctrl/Makefile > > @@ -48,6 +48,7 @@ obj-$(CONFIG_PINCTRL_PIC32) += pinctrl-pic32.o > > obj-$(CONFIG_PINCTRL_PISTACHIO) += pinctrl-pistachio.o > > obj-$(CONFIG_PINCTRL_RK805) += pinctrl-rk805.o > > obj-$(CONFIG_PINCTRL_ROCKCHIP) += pinctrl-rockchip.o > > +obj-$(CONFIG_PINCTRL_RP1) += pinctrl-rp1.o > > obj-$(CONFIG_PINCTRL_SCMI) += pinctrl-scmi.o > > obj-$(CONFIG_PINCTRL_SINGLE) += pinctrl-single.o > > obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o > > diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c > > new file mode 100644 > > index 000000000000..0d081f75d2ec > > --- /dev/null > > +++ b/drivers/pinctrl/pinctrl-rp1.c > > @@ -0,0 +1,789 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Driver for Raspberry Pi RP1 GPIO unit > > + * > > + * Copyright (C) 2023 Raspberry Pi Ltd. > > + * > > + * This driver is inspired by: > > + * pinctrl-bcm2835.c, please see original file for copyright information > > + */ > > + > ... > > + > > +static struct irq_chip rp1_gpio_irq_chip = { > > + .name = MODULE_NAME, > > + .irq_enable = rp1_gpio_irq_enable, > > + .irq_disable = rp1_gpio_irq_disable, > > + .irq_set_type = rp1_gpio_irq_set_type, > > + .irq_ack = rp1_gpio_irq_ack, > > + .irq_mask = rp1_gpio_irq_disable, > > + .irq_unmask = rp1_gpio_irq_enable, > > + .flags = IRQCHIP_IMMUTABLE, > Sorry not sure, but doesn't this miss GPIOCHIP_IRQ_RESOURCE_HELPERS here? Right. Added. Thanks, Andrea > > Thanks