From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: lee@kernel.org, giometti@enneenne.com,
gregkh@linuxfoundation.org, raymond.tan@intel.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] gpio: elkhartlake: depend on MFD_INTEL_EHL_PSE_GPIO
Date: Thu, 13 Mar 2025 11:19:28 +0200 [thread overview]
Message-ID: <Z9KjIAMfRIegA2vI@black.fi.intel.com> (raw)
In-Reply-To: <Z9HTU2BlXIa95S0V@smile.fi.intel.com>
On Wed, Mar 12, 2025 at 08:32:51PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 12, 2025 at 07:03:01PM +0200, Raag Jadav wrote:
> > On Wed, Mar 12, 2025 at 01:00:35PM +0200, Andy Shevchenko wrote:
> > > On Tue, Mar 11, 2025 at 08:37:26AM +0200, Raag Jadav wrote:
> > > > On Fri, Mar 07, 2025 at 10:52:28AM +0530, Raag Jadav wrote:
> > > > > Now that we have Intel MFD driver for PSE GPIO, depend on it.
> > >
> > > > Andy, any guidance on GPIO?
> > >
> > > I'm not sure what we are waiting here from me. Hadn't I reviewed your GPIO
> > > part already?
> >
> > Ah, I added MFD dependency for leaf drivers after your v1 review.
> > So this one seems missing the tag. Can I add it?
>
> I see, but this can be added later on.
> And on the second thought, do we accept the configurations
> when user wants to have GPIO on EHL, and doesn't care about TIO?
Yes, here we're making the leaf driver (GPIO) depend on MFD regardless
of what TIO config is.
> Maybe this patch is not needed after all?
My understanding is that GPIO should depend on MFD. Not much point in
adding a standalone leaf driver right?
Raag
next prev parent reply other threads:[~2025-03-13 9:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 5:22 [PATCH v3 0/5] Introduce Intel Elkhart Lake PSE TIO Raag Jadav
2025-03-07 5:22 ` [PATCH v3 1/5] mfd: intel_ehl_pse_gpio: Introduce Intel Elkhart Lake PSE GPIO and TIO Raag Jadav
2025-03-14 12:44 ` Lee Jones
2025-03-14 13:39 ` Andy Shevchenko
2025-03-14 13:57 ` Lee Jones
2025-03-14 14:20 ` Andy Shevchenko
2025-03-14 18:01 ` Raag Jadav
2025-03-21 5:28 ` Raag Jadav
2025-03-21 13:04 ` Greg KH
2025-03-21 13:22 ` Andy Shevchenko
2025-03-26 0:45 ` Greg KH
2025-03-26 9:01 ` Andy Shevchenko
2025-03-26 13:50 ` Greg KH
2025-03-07 5:22 ` [PATCH v3 2/5] gpio: elkhartlake: depend on MFD_INTEL_EHL_PSE_GPIO Raag Jadav
2025-03-11 6:37 ` Raag Jadav
2025-03-12 11:00 ` Andy Shevchenko
2025-03-12 17:03 ` Raag Jadav
2025-03-12 18:32 ` Andy Shevchenko
2025-03-13 9:19 ` Raag Jadav [this message]
2025-03-13 14:00 ` Andy Shevchenko
2025-03-13 14:24 ` Raag Jadav
2025-03-07 5:22 ` [PATCH v3 3/5] pps: generators: tio: split pps_gen_tio.h Raag Jadav
2025-03-07 5:22 ` [PATCH v3 4/5] pps: generators: tio: move to match_data() model Raag Jadav
2025-03-07 5:22 ` [PATCH v3 5/5] pps: generators: tio: Introduce Intel Elkhart Lake PSE TIO Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9KjIAMfRIegA2vI@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raymond.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).