From: andy.shevchenko@gmail.com
To: Devi Priya <quic_devipriy@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, linus.walleij@linaro.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com,
dmitry.baryshkov@linaro.org, nfraprado@collabora.com,
broonie@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, quic_srichara@quicinc.com,
quic_gokulsri@quicinc.com, quic_sjaganat@quicinc.com,
quic_kathirav@quicinc.com, quic_arajkuma@quicinc.com,
quic_anusha@quicinc.com, quic_poovendh@quicinc.com
Subject: Re: [PATCH V8 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver
Date: Tue, 7 Mar 2023 01:58:17 +0200 [thread overview]
Message-ID: <ZAZ+GeGu8mW1XqpG@surfacebook> (raw)
In-Reply-To: <20230214163116.9924-5-quic_devipriy@quicinc.com>
Tue, Feb 14, 2023 at 10:01:13PM +0530, Devi Priya kirjoitti:
> Add pinctrl definitions for the TLMM of IPQ9574
...
> + depends on OF
No compile test on non-OF configurations?
> + depends on ARM64 || COMPILE_TEST
...
> +#define FUNCTION(fname) \
PINCTRL_PINFUNCTION() ?
> + [msm_mux_##fname] = { \
> + .name = #fname, \
> + .groups = fname##_groups, \
> + .ngroups = ARRAY_SIZE(fname##_groups), \
> + }
...
> +#define REG_SIZE 0x1000
> +#define PINGROUP(id, f1, f2, f3, f4, f5, f6, f7, f8, f9) \
> + { \
> + .name = "gpio" #id, \
> + .pins = gpio##id##_pins, \
> + .npins = (unsigned int)ARRAY_SIZE(gpio##id##_pins), \
Can you embed struct pingroup?
> + .funcs = (int[]){ \
> + msm_mux_gpio, /* gpio mode */ \
> + msm_mux_##f1, \
> + msm_mux_##f2, \
> + msm_mux_##f3, \
> + msm_mux_##f4, \
> + msm_mux_##f5, \
> + msm_mux_##f6, \
> + msm_mux_##f7, \
> + msm_mux_##f8, \
> + msm_mux_##f9 \
> + }, \
> + .nfuncs = 10, \
> + .ctl_reg = REG_SIZE * id, \
> + .io_reg = 0x4 + REG_SIZE * id, \
> + .intr_cfg_reg = 0x8 + REG_SIZE * id, \
> + .intr_status_reg = 0xc + REG_SIZE * id, \
> + .intr_target_reg = 0x8 + REG_SIZE * id, \
> + .mux_bit = 2, \
> + .pull_bit = 0, \
> + .drv_bit = 6, \
> + .oe_bit = 9, \
> + .in_bit = 0, \
> + .out_bit = 1, \
> + .intr_enable_bit = 0, \
> + .intr_status_bit = 0, \
> + .intr_target_bit = 5, \
> + .intr_target_kpss_val = 3, \
> + .intr_raw_status_bit = 4, \
> + .intr_polarity_bit = 1, \
> + .intr_detection_bit = 2, \
> + .intr_detection_width = 2, \
> + }
...
> + PINGROUP(62, blsp1_spi, audio_sec, audio_pdm1, audio_sec, pta, prng_rosc2, gcc_plltest,
> + _, _),
Can be one line.
...
> +static const struct of_device_id ipq9574_pinctrl_of_match[] = {
> + { .compatible = "qcom,ipq9574-tlmm", },
> + { },
No comma for terminator line.
> +};
No MODULE_DEVICE_TABLE()?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-06 23:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 16:31 [PATCH V8 0/7] Add minimal boot support for IPQ9574 Devi Priya
2023-02-14 16:31 ` [PATCH V8 1/7] dt-bindings: clock: Add ipq9574 clock and reset definitions Devi Priya
2023-02-28 10:01 ` Varadarajan Narayanan
2023-03-03 13:27 ` Devi Priya
2023-02-14 16:31 ` [PATCH V8 2/7] clk: qcom: Add Global Clock Controller driver for IPQ9574 Devi Priya
2023-02-14 16:31 ` [PATCH V8 3/7] dt-bindings: pinctrl: qcom: Add support " Devi Priya
2023-02-16 10:36 ` Krzysztof Kozlowski
2023-02-14 16:31 ` [PATCH V8 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver Devi Priya
2023-03-06 23:58 ` andy.shevchenko [this message]
2023-03-08 9:52 ` Devi Priya
2023-03-08 13:24 ` Andy Shevchenko
2023-03-15 11:22 ` Devi Priya
2023-02-14 16:31 ` [PATCH V8 5/7] dt-bindings: arm: qcom: Add ipq9574 compatible Devi Priya
2023-02-14 16:31 ` [PATCH V8 6/7] arm64: dts: qcom: Add ipq9574 SoC and AL02 board support Devi Priya
2023-02-14 16:31 ` [PATCH V8 7/7] arm64: defconfig: Enable IPQ9574 SoC base configs Devi Priya
2023-03-16 3:21 ` (subset) [PATCH V8 0/7] Add minimal boot support for IPQ9574 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAZ+GeGu8mW1XqpG@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).