From: andy.shevchenko@gmail.com
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pwm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-gpio@vger.kernel.org,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v6 06/13] drivers: pinctrl: renesas: Add RZ/G2L POEG driver support
Date: Tue, 7 Mar 2023 01:35:58 +0200 [thread overview]
Message-ID: <ZAZ43tylTNxPIun8@surfacebook> (raw)
In-Reply-To: <20230306090014.128732-7-biju.das.jz@bp.renesas.com>
Mon, Mar 06, 2023 at 09:00:07AM +0000, Biju Das kirjoitti:
> The output pins of the RZ/G2L general PWM timer (GPT) can be disabled
> by using the port output enabling function for the GPT (POEG).
>
> Add basic support using s/w control through generic pincontrol sysfs to
> enable/disable output from GPT by registering with RZ/G2L pincontrol
> driver.
You have wrong Subject prefix.
...
> +static void rzg2l_poeg_write(struct rzg2l_poeg_chip *chip, u32 data)
> +{
> + iowrite32(data, chip->mmio);
> +}
> +
> +static u32 rzg2l_poeg_read(struct rzg2l_poeg_chip *chip)
> +{
> + return ioread32(chip->mmio);
> +}
Why not regmap MMIO?
...
> +static struct platform_driver rzg2l_poeg_driver = {
> + .driver = {
> + .name = "rzg2l-poeg",
> + .of_match_table = of_match_ptr(rzg2l_poeg_of_table),
Why do you need of_match_ptr()?
> + },
> + .probe = rzg2l_poeg_probe,
> + .remove = rzg2l_poeg_remove,
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-06 23:36 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 9:00 [PATCH v6 00/13] Add pinctrl sysfs and RZ/G2L POEG support Biju Das
2023-03-06 9:00 ` [PATCH v6 01/13] pinctrl: core: Add pinctrl_get_device() Biju Das
2023-03-06 23:33 ` andy.shevchenko
2023-03-07 8:13 ` Biju Das
2023-03-09 12:54 ` Andy Shevchenko
2023-03-09 13:26 ` Biju Das
2023-03-09 13:44 ` Andy Shevchenko
2023-03-09 14:19 ` Biju Das
2023-03-13 20:42 ` Biju Das
2023-03-13 22:05 ` Linus Walleij
2023-03-14 8:27 ` Biju Das
2023-03-14 8:42 ` Linus Walleij
2023-03-28 7:08 ` Biju Das
2023-03-14 9:33 ` Geert Uytterhoeven
2023-03-14 11:33 ` Biju Das
2023-03-15 8:00 ` Geert Uytterhoeven
2023-03-09 13:05 ` Linus Walleij
2023-03-09 13:18 ` Biju Das
2023-03-06 9:00 ` [PATCH v6 02/13] pinctrl: Add poutdisops variable to struct pinctrl_desc Biju Das
2023-03-06 9:00 ` [PATCH v6 03/13] pinctrl: Add sysfs support Biju Das
2023-03-06 23:38 ` andy.shevchenko
2023-03-07 8:54 ` Biju Das
2023-03-07 13:41 ` Linus Walleij
2023-03-07 14:43 ` Biju Das
2023-03-07 15:15 ` Greg KH
2023-03-28 7:07 ` Biju Das
2023-03-07 14:46 ` Greg KH
2023-03-06 9:00 ` [PATCH v6 04/13] pinctrl: renesas: rzg2l: Add pin output disable support Biju Das
2023-03-06 9:00 ` [PATCH v6 06/13] drivers: pinctrl: renesas: Add RZ/G2L POEG driver support Biju Das
2023-03-06 23:35 ` andy.shevchenko [this message]
2023-03-07 8:53 ` Biju Das
2023-03-07 9:58 ` Andy Shevchenko
2023-03-07 10:10 ` Biju Das
2023-03-07 12:30 ` Andy Shevchenko
2023-03-07 12:39 ` Biju Das
2023-03-06 9:00 ` [DO NOT APPLY PATCH v6 07/13] pwm: rzg2l-gpt: Add support for output disable request from gpt Biju Das
2023-03-06 9:00 ` [DO NOT APPLY PATCH v6 08/13] pinctrl: renesas: rzg2l-poeg: Add support for GPT Output-Disable Request Biju Das
2023-03-06 9:00 ` [DO NOT APPLY PATCH v6 09/13] pwm: rzg2l-gpt: Add support for output disable when both output low Biju Das
2023-03-06 9:00 ` [DO NOT APPLY PATCH v6 10/13] pinctrl: renesas: rzg2l-poeg: output-disable request from GPT when both outputs are low Biju Das
2023-03-06 23:39 ` andy.shevchenko
2023-03-07 8:57 ` Biju Das
2023-03-06 9:00 ` [DO NOT APPLY PATCH v6 11/13] pwm: rzg2l-gpt: Add support for output disable on dead time error Biju Das
2023-03-06 9:00 ` [DO NOT APPLY PATCH v6 12/13] pinctrl: renesas: rzg2l-poeg: output-disable request from GPT " Biju Das
2023-03-06 9:00 ` [DO NOT APPLY PATCH v6 13/13] tools/poeg: Add test app for poeg Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAZ43tylTNxPIun8@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).