From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C62AC64EC4 for ; Mon, 6 Mar 2023 23:33:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbjCFXdO (ORCPT ); Mon, 6 Mar 2023 18:33:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbjCFXdL (ORCPT ); Mon, 6 Mar 2023 18:33:11 -0500 Received: from fgw22-7.mail.saunalahti.fi (fgw22-7.mail.saunalahti.fi [62.142.5.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB2B0769D for ; Mon, 6 Mar 2023 15:33:04 -0800 (PST) Received: from localhost (88-113-24-128.elisa-laajakaista.fi [88.113.24.128]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id 3c75c19d-bc77-11ed-a9de-005056bdf889; Tue, 07 Mar 2023 01:33:02 +0200 (EET) From: andy.shevchenko@gmail.com Date: Tue, 7 Mar 2023 01:33:01 +0200 To: Biju Das Cc: Linus Walleij , linux-gpio@vger.kernel.org, Geert Uytterhoeven , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v6 01/13] pinctrl: core: Add pinctrl_get_device() Message-ID: References: <20230306090014.128732-1-biju.das.jz@bp.renesas.com> <20230306090014.128732-2-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230306090014.128732-2-biju.das.jz@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Mon, Mar 06, 2023 at 09:00:02AM +0000, Biju Das kirjoitti: > Add pinctrl_get_device() to find a device handle associated with > a pincontrol group(i.e. by matching function name and group name for a > device). This device handle can then be used for finding match for the > pin output disable device that protects device against short circuits > on the pins. Not sure I understand the use case. Please, create a better commit message. Also it is missing the explanation why there will be no collisions when looking by the same pair of function and group name from different device. (Always imagine that you have 2+ same IP blocks on the platform before doing any pin control core work. This will help you to design it properly. ) -- With Best Regards, Andy Shevchenko