From: andy.shevchenko@gmail.com
To: Lizhe <sensor1010@163.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, geert+renesas@glider.be,
info@metux.net, shc_work@mail.ru, j-keerthy@ti.com,
hoan@os.amperecomputing.com, fancer.lancer@gmail.com,
orsonzhai@gmail.com, baolin.wang@linux.alibaba.com,
zhang.lyra@gmail.com, kaloz@openwrt.org, khalasa@piap.pl,
keguang.zhang@gmail.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH v1] drivers/gpio: remove redundant platform_set_drvdata()
Date: Tue, 7 Mar 2023 00:54:23 +0200 [thread overview]
Message-ID: <ZAZvH6CFtH4I1BOm@surfacebook> (raw)
In-Reply-To: <20230306151532.23246-1-sensor1010@163.com>
Mon, Mar 06, 2023 at 11:15:32PM +0800, Lizhe kirjoitti:
> remove redundant platform_set_drvdata(),
> Because there is no place to use the platform_get_drvdata
The commit message has to be improved:
- English grammar and punctuation
- style of func()
- clearer wording on what it all means
Note, to get driver data the dev_get_drvdata() can be used. Do you aware about
this? And hHow did you check these drivers?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-06 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 15:15 [PATCH v1] drivers/gpio: remove redundant platform_set_drvdata() Lizhe
2023-03-06 22:54 ` andy.shevchenko [this message]
2023-03-08 10:26 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAZvH6CFtH4I1BOm@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brgl@bgdev.pl \
--cc=fancer.lancer@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hoan@os.amperecomputing.com \
--cc=info@metux.net \
--cc=j-keerthy@ti.com \
--cc=kaloz@openwrt.org \
--cc=keguang.zhang@gmail.com \
--cc=khalasa@piap.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=sensor1010@163.com \
--cc=shc_work@mail.ru \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).