From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Wes Tarro <wes.tarro@azuresummit.com>
Subject: Re: [libgpiod][PATCH] tools: gpiomon: fix setting event clock type
Date: Wed, 15 Mar 2023 16:03:43 +0200 [thread overview]
Message-ID: <ZBHQP3e0/iDs0Jyn@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdaBKxSbRxCoYRyNJMfjiDZ5TswYg7s-Z0Loy+aha4ZFLQ@mail.gmail.com>
On Wed, Mar 15, 2023 at 09:44:17AM +0100, Linus Walleij wrote:
> On Wed, Mar 15, 2023 at 9:35 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Fix an inverted logic bug when parsing event clock type in gpiomon.
> >
> > Fixes: 8ffb6489286f ("tools: line name focussed rework")
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > Reported-by: Wes Tarro <wes.tarro@azuresummit.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> > - if (strcmp(option, "hte") != 0)
> > + if (strcmp(option, "hte") == 0)
>
> I tend to code if (!strcmp(option, "hte")) but taste differs.
Pity we don't have match_string() API in a libc or somewhere in the user space.
Allows to avoid such mistakes at once.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-15 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 8:34 [libgpiod][PATCH] tools: gpiomon: fix setting event clock type Bartosz Golaszewski
2023-03-15 8:44 ` Linus Walleij
2023-03-15 14:03 ` Andy Shevchenko [this message]
2023-03-15 14:10 ` Bartosz Golaszewski
2023-03-15 14:04 ` Andy Shevchenko
2023-03-15 18:36 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBHQP3e0/iDs0Jyn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=warthog618@gmail.com \
--cc=wes.tarro@azuresummit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox