linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Drop map from handle_mask_sync() parameters
Date: Mon, 20 Mar 2023 17:32:22 +0200	[thread overview]
Message-ID: <ZBh8hgdRq+kydPBw@smile.fi.intel.com> (raw)
In-Reply-To: <cover.1679323449.git.william.gray@linaro.org>

On Mon, Mar 20, 2023 at 10:50:14AM -0400, William Breathitt Gray wrote:
> Changes in v3:
>  - Inline dio48gpio->map usage in dio48e_handle_mask_sync() to avoid
>    redefining map parameter
> 
> Remove the map parameter from the struct regmap_irq_chip callback
> handle_mask_sync() because it can be passed via the irq_drv_data
> parameter instead. The gpio-104-dio-48e driver is the only consumer of
> this callback and is thus updated accordingly.
> 
> A couple pending patchsets also utilize handle_mask_sync() [0][1], so
> it'll be useful to merge the changes in this series first to avoid
> subsequent noise adjusting the dependent drivers.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I believe this should go to the immutable branch somewhere, so GPIO and regmap
subsystems can pull from.

> [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@linaro.org/
> [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@linaro.org/
> 
> William Breathitt Gray (2):
>   gpio: 104-dio-48e: Implement struct dio48e_gpio
>   regmap-irq: Drop map from handle_mask_sync() parameters
> 
>  drivers/base/regmap/regmap-irq.c |  5 ++---
>  drivers/gpio/gpio-104-dio-48e.c  | 37 +++++++++++++++++++++-----------
>  include/linux/regmap.h           |  3 +--
>  3 files changed, 28 insertions(+), 17 deletions(-)
> 
> 
> base-commit: 03810031c91dfe448cd116ee987d5dc4139006f4
> -- 
> 2.39.2
> 

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2023-03-20 15:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 14:50 [PATCH v3 0/2] Drop map from handle_mask_sync() parameters William Breathitt Gray
2023-03-20 14:50 ` [PATCH v3 1/2] gpio: 104-dio-48e: Implement struct dio48e_gpio William Breathitt Gray
2023-04-07 11:47   ` [RESEND PATCH " William Breathitt Gray
2023-04-11 20:23   ` [PATCH " Mark Brown
2023-04-11 18:36     ` William Breathitt Gray
2023-04-11 21:15       ` Mark Brown
2023-04-11 21:35         ` William Breathitt Gray
2023-04-21  8:20           ` Linus Walleij
2023-03-20 14:50 ` [PATCH v3 2/2] regmap-irq: Drop map from handle_mask_sync() parameters William Breathitt Gray
2023-04-07 11:47   ` [RESEND PATCH " William Breathitt Gray
2023-03-20 15:32 ` Andy Shevchenko [this message]
2023-03-22 16:55   ` [PATCH v3 0/2] " Bartosz Golaszewski
2023-04-07 11:47 ` [RESEND PATCH " William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBh8hgdRq+kydPBw@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=william.gray@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).