From: andy.shevchenko@gmail.com
To: Lizhe <sensor1010@163.com>
Cc: linus.walleij@linaro.org, orsonzhai@gmail.com,
baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com,
andriy.shevchenko@linux.intel.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl:sprd: Check if the pinctrl_dev still exists
Date: Sun, 30 Apr 2023 12:43:46 +0300 [thread overview]
Message-ID: <ZE44Uj0-UAvQkY6L@surfacebook> (raw)
In-Reply-To: <20230430042254.7543-1-sensor1010@163.com>
Sun, Apr 30, 2023 at 12:22:54PM +0800, Lizhe kirjoitti:
> to check if the pinctrl_dev still exists before calling
> pinctrl_unregister().
Besides commit message has no explanation (and English grammar
incorrectness)...
...
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -1115,7 +1115,9 @@ int sprd_pinctrl_remove(struct platform_device *pdev)
> {
> struct sprd_pinctrl *sprd_pctl = platform_get_drvdata(pdev);
>
> - pinctrl_unregister(sprd_pctl->pctl);
> + if (sprd_pctl->dev)
...this code is not needed.
> + pinctrl_unregister(sprd_pctl->pctl);
> return 0;
> }
NAK.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-04-30 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 4:22 [PATCH] pinctrl:sprd: Check if the pinctrl_dev still exists Lizhe
2023-04-30 9:43 ` andy.shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-30 14:01 Lizhe
2023-04-30 19:18 ` andy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZE44Uj0-UAvQkY6L@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=sensor1010@163.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).