linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: andy.shevchenko@gmail.com
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: andy.shevchenko@gmail.com, agross@kernel.org,
	andersson@kernel.org, konrad.dybcio@linaro.org,
	linus.walleij@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com,
	manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v6 4/4] pinctrl: qcom: Add SDX75 pincontrol driver
Date: Wed, 10 May 2023 17:19:30 +0300	[thread overview]
Message-ID: <ZFun8m5y-r0yUHhq@surfacebook> (raw)
In-Reply-To: <1683718725-14869-5-git-send-email-quic_rohiagar@quicinc.com>

Wed, May 10, 2023 at 05:08:45PM +0530, Rohit Agarwal kirjoitti:
> Add initial Qualcomm SDX75 pinctrl driver to support pin configuration
> with pinctrl framework for SDX75 SoC.
> While at it, reordering the SDX65 entry.

...

> +#define FUNCTION(n)							\
> +	[msm_mux_##n] = {						\
> +			.func = PINCTRL_PINFUNCTION(#n,			\
> +					n##_groups,			\
> +					ARRAY_SIZE(n##_groups))		\
> +			}

But don't you now have MSM_PIN_FUNCTION() macro?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-05-10 14:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 11:38 [PATCH v6 0/4] Add pinctrl support for SDX75 Rohit Agarwal
2023-05-10 11:38 ` [PATCH v6 1/4] dt-bindings: pinctrl: qcom: Add SDX75 pinctrl devicetree compatible Rohit Agarwal
2023-05-10 11:38 ` [PATCH v6 2/4] pinctrl: qcom: Remove the msm_function struct Rohit Agarwal
2023-05-10 14:06   ` andy.shevchenko
2023-05-10 11:38 ` [PATCH v6 3/4] pinctrl: qcom: Refactor generic qcom pinctrl driver Rohit Agarwal
2023-05-10 14:08   ` andy.shevchenko
2023-05-10 11:38 ` [PATCH v6 4/4] pinctrl: qcom: Add SDX75 pincontrol driver Rohit Agarwal
2023-05-10 14:19   ` andy.shevchenko [this message]
2023-05-10 14:30     ` Rohit Agarwal
2023-05-10 14:34       ` Andy Shevchenko
2023-05-10 14:35         ` Rohit Agarwal
2023-05-10 12:15 ` [PATCH v6 0/4] Add pinctrl support for SDX75 Rohit Agarwal
2023-05-10 14:02   ` Andy Shevchenko
2023-05-10 14:05     ` Krzysztof Kozlowski
2023-05-10 14:32       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFun8m5y-r0yUHhq@surfacebook \
    --to=andy.shevchenko@gmail.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=quic_rohiagar@quicinc.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).