From: andy.shevchenko@gmail.com
To: Lizhe <sensor1010@163.com>
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drivers/pinconf.c: Remove redundant check for the existence of the member
Date: Mon, 15 May 2023 00:10:39 +0300 [thread overview]
Message-ID: <ZGFOT9cWNTzJDXo7@surfacebook> (raw)
In-Reply-To: <20230514165932.251200-1-sensor1010@163.com>
Mon, May 15, 2023 at 12:59:32AM +0800, Lizhe kirjoitti:
> "pin_config_set" in pinconf_ops.
>
> In the function of registering pinctrl_dev, pinctrl_init_controller(),
> a non-null check has already been performed on the members
> pin_config_set and pin_config_group_set in the ops structure.
NAK.
Try to analyse what `if (!foo && !bar)` means from the logic perspective and
deduce from that the problem in your proposal.
P.S. It's not the first wrong proposed change from you. Dunno if you even
trying to read the code...
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-05-14 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 16:59 [PATCH v1] drivers/pinconf.c: Remove redundant check for the existence of the member Lizhe
2023-05-14 21:10 ` andy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGFOT9cWNTzJDXo7@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sensor1010@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).