From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-gpio-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 89C64C7EE24
	for <linux-gpio@archiver.kernel.org>; Mon, 15 May 2023 18:34:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236270AbjEOSem (ORCPT <rfc822;linux-gpio@archiver.kernel.org>);
        Mon, 15 May 2023 14:34:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40432 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S243502AbjEOSem (ORCPT
        <rfc822;linux-gpio@vger.kernel.org>); Mon, 15 May 2023 14:34:42 -0400
Received: from fgw23-7.mail.saunalahti.fi (fgw23-7.mail.saunalahti.fi [62.142.5.84])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF95F15276
        for <linux-gpio@vger.kernel.org>; Mon, 15 May 2023 11:34:40 -0700 (PDT)
Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95])
        by fgw23.mail.saunalahti.fi (Halon) with ESMTP
        id 250eb140-f34f-11ed-b972-005056bdfda7;
        Mon, 15 May 2023 21:34:37 +0300 (EEST)
From:   andy.shevchenko@gmail.com
Date:   Mon, 15 May 2023 21:34:36 +0300
To:     Andrew Davis <afd@ti.com>
Cc:     Peter Tyser <ptyser@xes-inc.com>,
        Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] gpio: pisosr: Use devm_gpiochip_add_data() to
 simplify remove path
Message-ID: <ZGJ7POc8Qm9pE_WZ@surfacebook>
References: <20230515174321.494714-1-afd@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230515174321.494714-1-afd@ti.com>
Precedence: bulk
List-ID: <linux-gpio.vger.kernel.org>
X-Mailing-List: linux-gpio@vger.kernel.org

Mon, May 15, 2023 at 12:43:21PM -0500, Andrew Davis kirjoitti:
> Use devm version of gpiochip add function to handle removal for us.
> 
> While here update copyright and module author.

...

> +static void pisosr_mutex_destroy(void *data)
> +{
> +	struct mutex *lock = data;
> +
> +	mutex_destroy(lock);
> +}

No need to cast void * explicitly.

static void pisosr_mutex_destroy(void *lock)
{
	mutex_destroy(lock);
}

-- 
With Best Regards,
Andy Shevchenko