From: andy.shevchenko@gmail.com
To: Ryan.Wanner@microchip.com
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
linus.walleij@linaro.org, ludovic.desroches@microchip.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/3] pinctrl: at91-pio4: Enable Push-Pull configuration
Date: Tue, 23 May 2023 19:27:23 +0300 [thread overview]
Message-ID: <ZGzpa5HVVCKzQu3E@surfacebook> (raw)
In-Reply-To: <d898c31277f6bce6f7d830edf4332ff605498c7b.1684313910.git.Ryan.Wanner@microchip.com>
Wed, May 17, 2023 at 01:54:04PM +0200, Ryan.Wanner@microchip.com kirjoitti:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Enable push-pull configuration. Remove integer value argument from
> open-drain configuration as it is discarded when pinconf function is
> called from gpiolib. Add push-pull do debug and get functions.
Right, thank you for fixing this!
Other comments below.
...
> + case PIN_CONFIG_DRIVE_PUSH_PULL:
> + conf &= (~ATMEL_PIO_OPD_MASK);
Parentheses are redundant.
> break;
...
> if (conf & ATMEL_PIO_OPD_MASK)
> seq_printf(s, "%s ", "open-drain");
> + if (!(conf & ATMEL_PIO_OPD_MASK))
> + seq_printf(s, "%s ", "push-pull");
As commented already by others, the else would be better.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-23 16:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 11:54 [PATCH 0/3] AT91 PIO4 push-pull enable Ryan.Wanner
2023-05-17 11:54 ` [PATCH 1/3] pinctrl: at91-pio4: Enable Push-Pull configuration Ryan.Wanner
2023-05-18 5:40 ` Claudiu.Beznea
2023-05-18 5:54 ` Claudiu.Beznea
2023-05-22 9:18 ` Nicolas Ferre
2023-05-23 16:27 ` andy.shevchenko [this message]
2023-05-24 8:50 ` Linus Walleij
2023-05-17 11:54 ` [PATCH 2/3] dt-bindings: pinctrl: at91-pio4: Add push-pull support Ryan.Wanner
2023-05-17 17:38 ` Conor Dooley
2023-05-17 17:50 ` Conor Dooley
2023-05-22 9:18 ` Nicolas Ferre
2023-05-24 8:50 ` Linus Walleij
2023-05-17 11:54 ` [PATCH 3/3] ARM: dts: at91: Return to boolean properties Ryan.Wanner
2023-05-22 9:22 ` Nicolas Ferre
2023-05-23 5:05 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGzpa5HVVCKzQu3E@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).