From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: joe.slater@windriver.com, linux-gpio@vger.kernel.org,
randy.macleod@windriver.com
Subject: Re: [v3][libgpiod][PATCH 1/1] gpio-tools-test.bats: modify delays in toggle test
Date: Tue, 6 Jun 2023 20:42:07 +0800 [thread overview]
Message-ID: <ZH8pnxccmgSPnb+9@sol> (raw)
In-Reply-To: <CAMRc=MfAjiJhc5qpuHu_=Zb7NhAnw4GFNXEFN8Gh9ZfV8NOWLw@mail.gmail.com>
On Tue, Jun 06, 2023 at 02:32:37PM +0200, Bartosz Golaszewski wrote:
> On Tue, Jun 6, 2023 at 5:43 AM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Mon, Jun 05, 2023 at 01:43:35PM -0700, joe.slater@windriver.com wrote:
> > > From: Joe Slater <joe.slater@windriver.com>
> > >
>
> Patch looks fine but interestingly, I'm not seeing any improvement in
> terms of execution times. Is this to be expected?
>
This patch, as it stands, doesn't address execution times, it addresses
the possibility of some delay throwing the test script and gpiomon out of
sync and making the test fail. So making the test more robust.
The toggle rate of the test is slow to reduce the likelyhood of sync
loss. With this change it should be possible to increase the toggle
rate and so reduce the test duration, without impacting test reliabilty,
but that has not been done (yet). And even then it would only reduce
the run time by a second or so.
Cheers,
Kent.
next prev parent reply other threads:[~2023-06-06 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 20:43 [v3][libgpiod][PATCH 1/1] gpio-tools-test.bats: modify delays in toggle test joe.slater
2023-06-06 3:43 ` Kent Gibson
2023-06-06 12:32 ` Bartosz Golaszewski
2023-06-06 12:42 ` Kent Gibson [this message]
2023-06-06 15:11 ` Slater, Joseph
2023-06-06 15:12 ` Bartosz Golaszewski
2023-06-15 9:54 ` Bartosz Golaszewski
2023-06-06 15:16 ` Bartosz Golaszewski
2023-06-06 15:19 ` Bartosz Golaszewski
2023-06-06 15:31 ` Slater, Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH8pnxccmgSPnb+9@sol \
--to=warthog618@gmail.com \
--cc=brgl@bgdev.pl \
--cc=joe.slater@windriver.com \
--cc=linux-gpio@vger.kernel.org \
--cc=randy.macleod@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox