From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F885C77B73 for ; Fri, 26 May 2023 22:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231416AbjEZWFj (ORCPT ); Fri, 26 May 2023 18:05:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230326AbjEZWFj (ORCPT ); Fri, 26 May 2023 18:05:39 -0400 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AC95E55 for ; Fri, 26 May 2023 15:04:58 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id f192b364-fc10-11ed-b3cf-005056bd6ce9; Sat, 27 May 2023 01:02:02 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Sat, 27 May 2023 01:02:01 +0300 To: Mukesh Ojha Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linus.walleij@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v6 2/5] pinctrl: qcom: Use qcom_scm_io_update_field() Message-ID: References: <1680076012-10785-1-git-send-email-quic_mojha@quicinc.com> <1680076012-10785-3-git-send-email-quic_mojha@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1680076012-10785-3-git-send-email-quic_mojha@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Wed, Mar 29, 2023 at 01:16:49PM +0530, Mukesh Ojha kirjoitti: > Use qcom_scm_io_update_field() exported function introduced > in last commit. ... > u32 val; > + u32 mask; Swapping their order may help with readability. ... > + mask = (7 << g->intr_target_bit); Why not GENMASK(2, 0) at the same time? -- With Best Regards, Andy Shevchenko