From: simon.guinot@sequanux.org
To: xingtong_wu@163.com
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
henning.schild@siemens.com, xingtong.wu@siemens.com
Subject: Re: [PATCH v2 1/1] gpio-f7188x: fix base values conflicts with other gpio pins
Date: Mon, 29 May 2023 14:26:29 +0200 [thread overview]
Message-ID: <ZHSZ9cK78qc5QeZD@localhost> (raw)
In-Reply-To: <20230529025011.2806-2-xingtong_wu@163.com>
[-- Attachment #1: Type: text/plain, Size: 9263 bytes --]
On Mon, May 29, 2023 at 10:50:12AM +0800, xingtong_wu@163.com wrote:
> From: "xingtong.wu" <xingtong.wu@siemens.com>
>
> switch pin base from static to automatic allocation to
> avoid conflicts and align with other gpio chip drivers
Hi xingtong,
I suppose this patch is correct but I am not a big fan.
It would be nice if a pin number found in the device datasheet could
still be converted into a Linux GPIO number by adding the base of the
first bank.
With this patch it is no longer possible. All the F7188x controllers
have holes in their pin namespace (between the banks/chips). And a base
number assigned dynamically to each chip won't take these holes into
account.
Simon
>
> Signed-off-by: xingtong.wu <xingtong.wu@siemens.com>
> ---
> drivers/gpio/gpio-f7188x.c | 138 ++++++++++++++++++-------------------
> 1 file changed, 69 insertions(+), 69 deletions(-)
>
> diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
> index f54ca5a1775e..3875fd940ccb 100644
> --- a/drivers/gpio/gpio-f7188x.c
> +++ b/drivers/gpio/gpio-f7188x.c
> @@ -163,7 +163,7 @@ static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value);
> static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset,
> unsigned long config);
>
> -#define F7188X_GPIO_BANK(_base, _ngpio, _regbase, _label) \
> +#define F7188X_GPIO_BANK(_ngpio, _regbase, _label) \
> { \
> .chip = { \
> .label = _label, \
> @@ -174,7 +174,7 @@ static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset,
> .direction_output = f7188x_gpio_direction_out, \
> .set = f7188x_gpio_set, \
> .set_config = f7188x_gpio_set_config, \
> - .base = _base, \
> + .base = -1, \
> .ngpio = _ngpio, \
> .can_sleep = true, \
> }, \
> @@ -191,98 +191,98 @@ static int f7188x_gpio_set_config(struct gpio_chip *chip, unsigned offset,
> #define f7188x_gpio_data_single(type) ((type) == nct6126d)
>
> static struct f7188x_gpio_bank f71869_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 6, 0xF0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> - F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> - F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> - F7188X_GPIO_BANK(50, 5, 0xA0, DRVNAME "-5"),
> - F7188X_GPIO_BANK(60, 6, 0x90, DRVNAME "-6"),
> + F7188X_GPIO_BANK(6, 0xF0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(8, 0xE0, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xD0, DRVNAME "-2"),
> + F7188X_GPIO_BANK(8, 0xC0, DRVNAME "-3"),
> + F7188X_GPIO_BANK(8, 0xB0, DRVNAME "-4"),
> + F7188X_GPIO_BANK(5, 0xA0, DRVNAME "-5"),
> + F7188X_GPIO_BANK(6, 0x90, DRVNAME "-6"),
> };
>
> static struct f7188x_gpio_bank f71869a_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 6, 0xF0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> - F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> - F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> - F7188X_GPIO_BANK(50, 5, 0xA0, DRVNAME "-5"),
> - F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-6"),
> - F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-7"),
> + F7188X_GPIO_BANK(6, 0xF0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(8, 0xE0, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xD0, DRVNAME "-2"),
> + F7188X_GPIO_BANK(8, 0xC0, DRVNAME "-3"),
> + F7188X_GPIO_BANK(8, 0xB0, DRVNAME "-4"),
> + F7188X_GPIO_BANK(5, 0xA0, DRVNAME "-5"),
> + F7188X_GPIO_BANK(8, 0x90, DRVNAME "-6"),
> + F7188X_GPIO_BANK(8, 0x80, DRVNAME "-7"),
> };
>
> static struct f7188x_gpio_bank f71882_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 8, 0xF0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> - F7188X_GPIO_BANK(30, 4, 0xC0, DRVNAME "-3"),
> - F7188X_GPIO_BANK(40, 4, 0xB0, DRVNAME "-4"),
> + F7188X_GPIO_BANK(8, 0xF0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(8, 0xE0, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xD0, DRVNAME "-2"),
> + F7188X_GPIO_BANK(4, 0xC0, DRVNAME "-3"),
> + F7188X_GPIO_BANK(4, 0xB0, DRVNAME "-4"),
> };
>
> static struct f7188x_gpio_bank f71889a_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 7, 0xF0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 7, 0xE0, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> - F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> - F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> - F7188X_GPIO_BANK(50, 5, 0xA0, DRVNAME "-5"),
> - F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-6"),
> - F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-7"),
> + F7188X_GPIO_BANK(7, 0xF0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(7, 0xE0, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xD0, DRVNAME "-2"),
> + F7188X_GPIO_BANK(8, 0xC0, DRVNAME "-3"),
> + F7188X_GPIO_BANK(8, 0xB0, DRVNAME "-4"),
> + F7188X_GPIO_BANK(5, 0xA0, DRVNAME "-5"),
> + F7188X_GPIO_BANK(8, 0x90, DRVNAME "-6"),
> + F7188X_GPIO_BANK(8, 0x80, DRVNAME "-7"),
> };
>
> static struct f7188x_gpio_bank f71889_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 7, 0xF0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 7, 0xE0, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> - F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> - F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> - F7188X_GPIO_BANK(50, 5, 0xA0, DRVNAME "-5"),
> - F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-6"),
> - F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-7"),
> + F7188X_GPIO_BANK(7, 0xF0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(7, 0xE0, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xD0, DRVNAME "-2"),
> + F7188X_GPIO_BANK(8, 0xC0, DRVNAME "-3"),
> + F7188X_GPIO_BANK(8, 0xB0, DRVNAME "-4"),
> + F7188X_GPIO_BANK(5, 0xA0, DRVNAME "-5"),
> + F7188X_GPIO_BANK(8, 0x90, DRVNAME "-6"),
> + F7188X_GPIO_BANK(8, 0x80, DRVNAME "-7"),
> };
>
> static struct f7188x_gpio_bank f81866_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 8, 0xF0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> - F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> - F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> - F7188X_GPIO_BANK(50, 8, 0xA0, DRVNAME "-5"),
> - F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-6"),
> - F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-7"),
> - F7188X_GPIO_BANK(80, 8, 0x88, DRVNAME "-8"),
> + F7188X_GPIO_BANK(8, 0xF0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(8, 0xE0, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xD0, DRVNAME "-2"),
> + F7188X_GPIO_BANK(8, 0xC0, DRVNAME "-3"),
> + F7188X_GPIO_BANK(8, 0xB0, DRVNAME "-4"),
> + F7188X_GPIO_BANK(8, 0xA0, DRVNAME "-5"),
> + F7188X_GPIO_BANK(8, 0x90, DRVNAME "-6"),
> + F7188X_GPIO_BANK(8, 0x80, DRVNAME "-7"),
> + F7188X_GPIO_BANK(8, 0x88, DRVNAME "-8"),
> };
>
>
> static struct f7188x_gpio_bank f81804_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 8, 0xF0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> - F7188X_GPIO_BANK(50, 8, 0xA0, DRVNAME "-3"),
> - F7188X_GPIO_BANK(60, 8, 0x90, DRVNAME "-4"),
> - F7188X_GPIO_BANK(70, 8, 0x80, DRVNAME "-5"),
> - F7188X_GPIO_BANK(90, 8, 0x98, DRVNAME "-6"),
> + F7188X_GPIO_BANK(8, 0xF0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(8, 0xE0, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xD0, DRVNAME "-2"),
> + F7188X_GPIO_BANK(8, 0xA0, DRVNAME "-3"),
> + F7188X_GPIO_BANK(8, 0x90, DRVNAME "-4"),
> + F7188X_GPIO_BANK(8, 0x80, DRVNAME "-5"),
> + F7188X_GPIO_BANK(8, 0x98, DRVNAME "-6"),
> };
>
> static struct f7188x_gpio_bank f81865_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 8, 0xF0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 8, 0xE0, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xD0, DRVNAME "-2"),
> - F7188X_GPIO_BANK(30, 8, 0xC0, DRVNAME "-3"),
> - F7188X_GPIO_BANK(40, 8, 0xB0, DRVNAME "-4"),
> - F7188X_GPIO_BANK(50, 8, 0xA0, DRVNAME "-5"),
> - F7188X_GPIO_BANK(60, 5, 0x90, DRVNAME "-6"),
> + F7188X_GPIO_BANK(8, 0xF0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(8, 0xE0, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xD0, DRVNAME "-2"),
> + F7188X_GPIO_BANK(8, 0xC0, DRVNAME "-3"),
> + F7188X_GPIO_BANK(8, 0xB0, DRVNAME "-4"),
> + F7188X_GPIO_BANK(8, 0xA0, DRVNAME "-5"),
> + F7188X_GPIO_BANK(5, 0x90, DRVNAME "-6"),
> };
>
> static struct f7188x_gpio_bank nct6126d_gpio_bank[] = {
> - F7188X_GPIO_BANK(0, 8, 0xE0, DRVNAME "-0"),
> - F7188X_GPIO_BANK(10, 8, 0xE4, DRVNAME "-1"),
> - F7188X_GPIO_BANK(20, 8, 0xE8, DRVNAME "-2"),
> - F7188X_GPIO_BANK(30, 8, 0xEC, DRVNAME "-3"),
> - F7188X_GPIO_BANK(40, 8, 0xF0, DRVNAME "-4"),
> - F7188X_GPIO_BANK(50, 8, 0xF4, DRVNAME "-5"),
> - F7188X_GPIO_BANK(60, 8, 0xF8, DRVNAME "-6"),
> - F7188X_GPIO_BANK(70, 8, 0xFC, DRVNAME "-7"),
> + F7188X_GPIO_BANK(8, 0xE0, DRVNAME "-0"),
> + F7188X_GPIO_BANK(8, 0xE4, DRVNAME "-1"),
> + F7188X_GPIO_BANK(8, 0xE8, DRVNAME "-2"),
> + F7188X_GPIO_BANK(8, 0xEC, DRVNAME "-3"),
> + F7188X_GPIO_BANK(8, 0xF0, DRVNAME "-4"),
> + F7188X_GPIO_BANK(8, 0xF4, DRVNAME "-5"),
> + F7188X_GPIO_BANK(8, 0xF8, DRVNAME "-6"),
> + F7188X_GPIO_BANK(8, 0xFC, DRVNAME "-7"),
> };
>
> static int f7188x_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> --
> 2.25.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-05-29 12:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 2:50 [PATCH v2 0/1] gpio-f7188x: fix base values conflicts with other gpio pins xingtong_wu
2023-05-29 2:50 ` [PATCH v2 1/1] " xingtong_wu
2023-05-29 12:26 ` simon.guinot [this message]
2023-05-29 13:03 ` Linus Walleij
2023-05-29 13:54 ` simon.guinot
2023-05-29 22:24 ` andy.shevchenko
2023-05-30 6:27 ` xingtong.wu
2023-05-30 10:53 ` andy.shevchenko
2023-05-30 11:10 ` andy.shevchenko
2023-05-30 17:53 ` simon.guinot
2023-05-30 21:42 ` Andy Shevchenko
2023-05-30 10:57 ` Henning Schild
2023-05-30 17:57 ` simon.guinot
2023-05-30 11:40 ` Linus Walleij
2023-05-29 13:02 ` Linus Walleij
2023-03-02 13:48 ` xingtong.wu
2023-06-16 7:53 ` Henning Schild
2023-08-31 7:28 ` xingtong.wu
2023-09-01 9:10 ` Bartosz Golaszewski
2023-09-11 7:04 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHSZ9cK78qc5QeZD@localhost \
--to=simon.guinot@sequanux.org \
--cc=brgl@bgdev.pl \
--cc=henning.schild@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xingtong.wu@siemens.com \
--cc=xingtong_wu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).