From: andy.shevchenko@gmail.com
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com,
l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements
Date: Tue, 30 May 2023 14:15:39 +0300 [thread overview]
Message-ID: <ZHXa23WFb9vNG-T2@surfacebook> (raw)
In-Reply-To: <20230529220708.66f7825fed9ee36b181128cf@hugovil.com>
Mon, May 29, 2023 at 10:07:08PM -0400, Hugo Villeneuve kirjoitti:
> On Tue, 30 May 2023 01:31:28 +0300
> andy.shevchenko@gmail.com wrote:
> > Mon, May 29, 2023 at 10:07:02AM -0400, Hugo Villeneuve kirjoitti:
> > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > >
> > > Hello,
> > > this patch series mainly fixes a GPIO regression and improve RS485 flags and
> > > properties detection from DT.
> > >
> > > It now also includes various small fixes and improvements that were previously
> > > sent as separate patches, but that made testing everything difficult.
> > >
> > > Patch 1 fixes an issue when debugging IOcontrol register. After testing the GPIO
> > > regression patches (patches 6 and 7, tests done by Lech Perczak), it appers that
> > > this patch is also necessary for having the correct IOcontrol register values.
> > >
> > > Patch 2 introduces a delay after a reset operation to respect datasheet
> > > timing recommandations.
> >
> > These two patches are w/o Fixes tag, they should be moved in the series further
> > as I explained before.
>
> Your explanation was not clear.
Sorry if it feels like this. The documentation should have more clarity
on the matter.
> Anyway, I moved them in position 7 and 8.
Thank you, but take also what Greg KH replied to you into consideration.
He is the maintainer and seems other patches needs some additional work
in the scope of Fixes / backport (see stable kernel patches flow in the
kernel documentation, which I also mentioned earlier).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-30 11:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 14:07 [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 1/9] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 2/9] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 3/9] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 4/9] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 5/9] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 6/9] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-05-29 14:16 ` Conor Dooley
2023-05-29 14:26 ` Hugo Villeneuve
2023-05-29 18:09 ` Conor Dooley
2023-05-29 18:19 ` Conor Dooley
2023-05-29 18:33 ` Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 7/9] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-05-29 16:10 ` Ilpo Järvinen
2023-05-29 22:38 ` andy.shevchenko
2023-05-30 15:36 ` Hugo Villeneuve
2023-05-30 21:56 ` Andy Shevchenko
2023-05-31 13:57 ` Hugo Villeneuve
2023-05-31 23:57 ` Hugo Villeneuve
2023-06-01 9:24 ` Andy Shevchenko
2023-05-30 10:25 ` Greg KH
2023-05-30 16:25 ` Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 8/9] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-05-29 14:07 ` [PATCH v4 9/9] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
2023-05-29 22:31 ` [PATCH v4 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements andy.shevchenko
2023-05-30 2:07 ` Hugo Villeneuve
2023-05-30 11:15 ` andy.shevchenko [this message]
2023-05-30 15:41 ` Hugo Villeneuve
2023-05-29 22:40 ` andy.shevchenko
2023-05-30 9:30 ` Lech Perczak
2023-05-30 13:08 ` Hugo Villeneuve
2023-05-31 10:43 ` Lech Perczak
2023-05-31 13:56 ` Hugo Villeneuve
2023-05-31 15:00 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHXa23WFb9vNG-T2@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).