From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
kernel@pengutronix.de,
"Andy Shevchenko" <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2 0/2] gpio: introduce hog properties with less ambiguity
Date: Wed, 31 May 2023 08:55:32 +0800 [thread overview]
Message-ID: <ZHabBOFfTBLOREgS@sol> (raw)
In-Reply-To: <CAMRc=Md3wCLuiS0tt2_v8Q1peqP+AkSrUNj1jg_8aZfDnj+2SQ@mail.gmail.com>
On Tue, May 30, 2023 at 09:15:55PM +0200, Bartosz Golaszewski wrote:
> On Tue, May 30, 2023 at 5:52 PM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Tue, May 30, 2023 at 05:19:44PM +0200, Uwe Kleine-König wrote:
> > > Hello,
> > >
> > > this is another approach after
> > > https://lore.kernel.org/linux-gpio/20210503210526.43455-1-u.kleine-koenig@pengutronix.de
> > > two years ago. I switched back to "active" and "inactive" from
> > > "asserted" and "deasserted". The poll about the naming is ambigous, but
> > > I think with a slight preference of active/inactive over
> > > asserted/deasserted (with my unbiased self preferring active/inactive,
> > > too :-)
> > >
> >
> > FWIW, this makes sense to me too - the active/inactive naming is used in
> > both the GPIO uAPI and libgpiod v2, so it would be consistent with that,
> > if nothing else.
> >
> > Bart, just wondering if gpio-sim should support the aliases as well?
> > I realise they don't support active-low, so polarity isn't an issue, and
> > it could even be confusing to support the alias, but just throwing it
> > out there...
> >
>
> I'm not sure what you need aliases for? Value is only shown, never
> stored (where you'd need "active", "inactive" strings).
>
I was thinking wrt the definition in DT - to allow the switch to
output-active etc throughout. And I suppose also for configuring the
hogs in configfs, but mainly the DT.
Cheers,
Kent.
next prev parent reply other threads:[~2023-05-31 0:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 15:19 [PATCH v2 0/2] gpio: introduce hog properties with less ambiguity Uwe Kleine-König
2023-05-30 15:19 ` [PATCH v2 1/2] dt-bindings: " Uwe Kleine-König
2023-05-30 22:20 ` Conor Dooley
2023-05-31 7:03 ` Uwe Kleine-König
2023-05-31 9:37 ` Conor Dooley
2023-05-31 6:18 ` Alexander Stein
2023-05-31 7:01 ` Uwe Kleine-König
2023-06-08 6:50 ` Geert Uytterhoeven
2023-06-07 21:09 ` Rob Herring
2023-05-30 15:19 ` [PATCH v2 2/2] gpio: use "active" and "inactive" instead of "high" and "low" for output hogs Uwe Kleine-König
2023-05-30 21:51 ` Andy Shevchenko
2023-05-31 6:58 ` Uwe Kleine-König
2023-05-31 9:51 ` Andy Shevchenko
2023-05-31 10:06 ` Uwe Kleine-König
2023-05-31 12:21 ` Andy Shevchenko
2023-05-31 12:23 ` Andy Shevchenko
2023-05-30 15:51 ` [PATCH v2 0/2] gpio: introduce hog properties with less ambiguity Kent Gibson
2023-05-30 19:15 ` Bartosz Golaszewski
2023-05-31 0:55 ` Kent Gibson [this message]
2023-05-31 8:15 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHabBOFfTBLOREgS@sol \
--to=warthog618@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).