From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: andy.shevchenko@gmail.com, Gabriel Matni <gabriel.matni@exfo.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [libgpiod][PATCH] tools: gpiomon: add timeout option
Date: Wed, 31 May 2023 09:26:23 +0800 [thread overview]
Message-ID: <ZHaiP/i6e38pH4G8@sol> (raw)
In-Reply-To: <CAMRc=Mc8Wnv_vTizO_UMkKenqr8n2g44x_KAURV7EQhD5ZQXwg@mail.gmail.com>
On Tue, May 30, 2023 at 09:10:12PM +0200, Bartosz Golaszewski wrote:
> On Tue, May 30, 2023 at 3:09 PM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Tue, May 30, 2023 at 02:21:18PM +0300, andy.shevchenko@gmail.com wrote:
> > > Tue, May 30, 2023 at 05:29:23PM +0800, Kent Gibson kirjoitti:
> > > > On Mon, May 29, 2023 at 08:20:44PM +0000, Gabriel Matni wrote:
> > > > > From: Gabriel Matni <gabriel.matni@exfo.com>
> > >
> > > ...
> >
> > I take it you would be in favour of an idle timeout option then?
> >
> > I'm puzzled why no one has ever asked for it before, if it is something
> > that is in demand.
> >
> > Cheers,
> > Kent.
>
> I do see value in this option. I'm not buying the argument about
> losing events - the same can be said in reverse - before we even
> request a line, we can lose events too.
>
> Gabriel: please address the issues pointed out by Kent if you still
> want to add this.
>
And consider adding a test to the test suite, assuming you have a
suitable test environment. There are timeout tests for gpioset there
already as an example.
Cheers,
Kent.
next prev parent reply other threads:[~2023-05-31 1:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 20:20 [libgpiod][PATCH] tools: gpiomon: add timeout option Gabriel Matni
2023-05-30 9:29 ` Kent Gibson
2023-05-30 11:21 ` andy.shevchenko
2023-05-30 13:09 ` Kent Gibson
2023-05-30 19:10 ` Bartosz Golaszewski
2023-05-31 1:26 ` Kent Gibson [this message]
2023-05-31 13:56 ` [E!] : " Gabriel Matni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHaiP/i6e38pH4G8@sol \
--to=warthog618@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=gabriel.matni@exfo.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).