From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC72C7EE2A for ; Fri, 2 Jun 2023 01:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230320AbjFBB75 (ORCPT ); Thu, 1 Jun 2023 21:59:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233168AbjFBB74 (ORCPT ); Thu, 1 Jun 2023 21:59:56 -0400 Received: from fgw22-7.mail.saunalahti.fi (fgw22-7.mail.saunalahti.fi [62.142.5.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FC40180 for ; Thu, 1 Jun 2023 18:59:55 -0700 (PDT) Received: from localhost (88-113-26-95.elisa-laajakaista.fi [88.113.26.95]) by fgw22.mail.saunalahti.fi (Halon) with ESMTP id 2a11ee8b-00e9-11ee-a9de-005056bdf889; Fri, 02 Jun 2023 04:59:53 +0300 (EEST) From: andy.shevchenko@gmail.com Date: Fri, 2 Jun 2023 04:59:52 +0300 To: Mario Limonciello Cc: Rafael Wysocki , hdegoede@redhat.com, linus.walleij@linaro.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org, S-k Shyam-sundar , Natikar Basavaraj Subject: Re: [PATCH v3 1/4] include/linux/suspend.h: Only show pm_pr_dbg messages at suspend/resume Message-ID: References: <20230601232923.1248-1-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601232923.1248-1-mario.limonciello@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Thu, Jun 01, 2023 at 06:29:20PM -0500, Mario Limonciello kirjoitti: > All uses in the kernel are currently already oriented around > suspend/resume. As some other parts of the kernel may also use these > messages in functions that could also be used outside of > suspend/resume, only enable in suspend/resume path. ... > * Remove pointless do/while I believe this is a joke. This guards against weirdness, like __pm_pr_dbg(foo) else bar; NAK for this particular change. -- With Best Regards, Andy Shevchenko