From: andy.shevchenko@gmail.com
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
Prathamesh Shete <pshete@nvidia.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v4 2/3] pinctrl: tegra: Add Tegra234 pinmux driver
Date: Sat, 3 Jun 2023 13:46:25 +0300 [thread overview]
Message-ID: <ZHsaAY1FQ57bsfC5@surfacebook> (raw)
In-Reply-To: <20230602141445.3012550-3-thierry.reding@gmail.com>
Fri, Jun 02, 2023 at 04:14:44PM +0200, Thierry Reding kirjoitti:
> From: Prathamesh Shete <pshete@nvidia.com>
>
> This change adds support for the two pin controllers found on Tegra234.
I'm not sure why my review got ignored. Did you receive it?
https://lore.kernel.org/linux-gpio/ZHlGTgdsqcGOmVN2@surfacebook/
It seems most of the comments are actual even for this version.
(Yes, you can ignore the struct pingroup usage as it's out of
the scope of this change, obviously.)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-03 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 14:14 [PATCH v4 0/3] pinctrl: tegra: Add Tegra234 pinmux driver Thierry Reding
2023-06-02 14:14 ` [PATCH v4 1/3] dt-bindings: pinctrl: Document Tegra234 pin controllers Thierry Reding
2023-06-04 10:32 ` Krzysztof Kozlowski
2023-06-02 14:14 ` [PATCH v4 2/3] pinctrl: tegra: Add Tegra234 pinmux driver Thierry Reding
2023-06-03 10:46 ` andy.shevchenko [this message]
2023-06-02 14:14 ` [PATCH v4 3/3] arm64: tegra: Add Tegra234 pin controllers Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHsaAY1FQ57bsfC5@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).