* Re: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property
2023-06-07 11:55 ` [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property Leonard Göhrs
@ 2023-06-07 16:36 ` andy.shevchenko
2023-06-08 13:24 ` Krzysztof Kozlowski
2023-06-08 13:24 ` Krzysztof Kozlowski
2023-06-13 14:54 ` Bartosz Golaszewski
2 siblings, 1 reply; 5+ messages in thread
From: andy.shevchenko @ 2023-06-07 16:36 UTC (permalink / raw)
To: Leonard Göhrs
Cc: Linus Walleij, Bartosz Golaszewski, Sungbo Eo, kernel,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree, linux-kernel
Wed, Jun 07, 2023 at 01:55:02PM +0200, Leonard Göhrs kirjoitti:
> This patch allows giving each of the controller's pins a meaningful
> name.
Isn't it gpio.txt already mentiones this?
Perhaps you need to convert that to YAML and use it here?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property
2023-06-07 16:36 ` andy.shevchenko
@ 2023-06-08 13:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-08 13:24 UTC (permalink / raw)
To: andy.shevchenko, Leonard Göhrs
Cc: Linus Walleij, Bartosz Golaszewski, Sungbo Eo, kernel,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio,
devicetree, linux-kernel
On 07/06/2023 18:36, andy.shevchenko@gmail.com wrote:
> Wed, Jun 07, 2023 at 01:55:02PM +0200, Leonard Göhrs kirjoitti:
>> This patch allows giving each of the controller's pins a meaningful
>> name.
>
> Isn't it gpio.txt already mentiones this?
TXT does not matter for DT schema. It's is already covered by dtschemas.
> Perhaps you need to convert that to YAML and use it here?
How would it solve anything? We still want constraints, right?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property
2023-06-07 11:55 ` [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property Leonard Göhrs
2023-06-07 16:36 ` andy.shevchenko
@ 2023-06-08 13:24 ` Krzysztof Kozlowski
2023-06-13 14:54 ` Bartosz Golaszewski
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-08 13:24 UTC (permalink / raw)
To: Leonard Göhrs, Linus Walleij, Bartosz Golaszewski, Sungbo Eo
Cc: kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-gpio, devicetree, linux-kernel
On 07/06/2023 13:55, Leonard Göhrs wrote:
> This patch allows giving each of the controller's pins a meaningful
> name.
>
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property
2023-06-07 11:55 ` [PATCH v1 3/8] dt-bindings: gpio: pca9570: add gpio-line-names property Leonard Göhrs
2023-06-07 16:36 ` andy.shevchenko
2023-06-08 13:24 ` Krzysztof Kozlowski
@ 2023-06-13 14:54 ` Bartosz Golaszewski
2 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2023-06-13 14:54 UTC (permalink / raw)
To: Leonard Göhrs
Cc: Linus Walleij, Sungbo Eo, kernel, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-gpio, devicetree,
linux-kernel
On Wed, Jun 7, 2023 at 1:57 PM Leonard Göhrs <l.goehrs@pengutronix.de> wrote:
>
> This patch allows giving each of the controller's pins a meaningful
> name.
>
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
> Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> index 5b0134304e51c..452f8972a9659 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
> @@ -24,6 +24,10 @@ properties:
> '#gpio-cells':
> const: 2
>
> + gpio-line-names:
> + minItems: 4
> + maxItems: 8
> +
> required:
> - compatible
> - reg
> --
> 2.39.2
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 5+ messages in thread