From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][PATCH 0/2] bindings: cxx: fix potential glitch in gpiosetcxx
Date: Mon, 12 Jun 2023 23:06:49 +0800 [thread overview]
Message-ID: <ZIc0iZayMhyRRGiM@sol> (raw)
In-Reply-To: <20230612145653.138615-1-brgl@bgdev.pl>
On Mon, Jun 12, 2023 at 04:56:51PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Kent,
>
> This is an alternative approach to the problem you raised with your gpioset
> patches. It adds a new helper method that allows to set all output values at
> request-time using the line_config's set_output_values() method.
>
> Please take a look and let me know what you think.
>
That works for me - it is waaaay less painful than the per-line approach.
Reviewed-by: Kent Gibson <warthog618@gmail.com>
for the series.
Though come to think of it, it could use tests as well.
But you can always add some subsequently.
Btw, this is also an example of the outcome I expected to see from
expanding the examples - identify common pain points and extend the API
to address them.
Cheers,
Kent.
prev parent reply other threads:[~2023-06-12 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 14:56 [libgpiod][PATCH 0/2] bindings: cxx: fix potential glitch in gpiosetcxx Bartosz Golaszewski
2023-06-12 14:56 ` [libgpiod][PATCH 1/2] bindings: cxx: provide request_builder::set_output_values() Bartosz Golaszewski
2023-06-12 14:56 ` [libgpiod][PATCH 2/2] bindings: cxx: examples: fix potential glitch in gpiosetcxx Bartosz Golaszewski
2023-06-12 15:06 ` Kent Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIc0iZayMhyRRGiM@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).