From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Joe Slater <joe.slater@windriver.com>,
linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [libgpiod][RFC/RFT PATCH] tools: tests: port tests to shunit2
Date: Thu, 15 Jun 2023 23:10:37 +0800 [thread overview]
Message-ID: <ZIsp7SU8RotOPvB+@sol> (raw)
In-Reply-To: <20230615143810.225755-1-brgl@bgdev.pl>
On Thu, Jun 15, 2023 at 04:38:10PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> BATS seems to run pretty slowly. Part of it may be the n+1 time parsing
> the test files mentioned in the BATS docs.
>
> This is a quick and dirty port of test cases to shunit2 - a different
> testing framework for shell scripts. It sped up test execution for me
> by ~40%.
>
That is a lot faster for me too:
Ran 165 tests.
OK
real 0m41.300s
user 0m10.122s
sys 0m22.926s
while it is > 2m30 with bats, so ~75% speedup.
Though I get these errors on some tests:
test_gpiodetect_all_chips
./gpio-tools-test.bash: line 40: assertContains: command not found
./gpio-tools-test.bash: line 40: assertContains: command not found
./gpio-tools-test.bash: line 40: assertContains: command not found
test_gpiodetect_a_chip
and the overall test suite still passed, which is a bit of a worry.
Hmmm, seems assertContains was added in 2.1.8 and I'm still on 2.1.6.
I'll have to update.
Overall looks promising.
Cheers,
Kent.
prev parent reply other threads:[~2023-06-15 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 14:38 [libgpiod][RFC/RFT PATCH] tools: tests: port tests to shunit2 Bartosz Golaszewski
2023-06-15 15:10 ` Kent Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIsp7SU8RotOPvB+@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=joe.slater@windriver.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).