From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Jadav, Raag" <raag.jadav@intel.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>,
"N, Pandith" <pandith.n@intel.com>
Subject: Re: [PATCH v4] pinctrl: intel: refine ->irq_set_type() hook
Date: Thu, 15 Jun 2023 18:16:28 +0300 [thread overview]
Message-ID: <ZIsrTNkW8BsUkeS9@smile.fi.intel.com> (raw)
In-Reply-To: <DM6PR11MB2779545C0ACBF833E857EBD28C5BA@DM6PR11MB2779.namprd11.prod.outlook.com>
On Thu, Jun 15, 2023 at 03:05:42PM +0000, Jadav, Raag wrote:
> > On Thu, Jun 15, 2023 at 01:35:19PM +0000, Jadav, Raag wrote:
...
> > > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-9 (-9)
> > > Function old new delta
> > > intel_gpio_irq_type 317 308 -9
> > > Total: Before=10469, After=10460, chg -0.09%
> >
> > Do I understand correctly that this is your patch + suggested above?
>
> Yes, this is tested with gcc 7.5.0 with default -O2.
> I see some reordering in disassembly even with this simple change,
> and I'm not entirely sure what kind of weird tricks gcc is pulling here.
For me gcc (Debian 12.2.0-14) 12.2.0 gives the same, +4 bytes.
I am going to apply v4 with suggested tweaks.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-15 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 12:50 [PATCH v4] pinctrl: intel: refine ->irq_set_type() hook Raag Jadav
2023-06-15 13:14 ` Andy Shevchenko
2023-06-15 13:35 ` Jadav, Raag
2023-06-15 14:09 ` Andy Shevchenko
2023-06-15 15:05 ` Jadav, Raag
2023-06-15 15:16 ` Andy Shevchenko [this message]
2023-06-15 15:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIsrTNkW8BsUkeS9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pandith.n@intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox