From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <treding@nvidia.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip
Date: Mon, 19 Jun 2023 13:41:43 +0300 [thread overview]
Message-ID: <ZJAw507ODTUX2elD@smile.fi.intel.com> (raw)
In-Reply-To: <87y1kipeui.wl-maz@kernel.org>
On Sat, Jun 17, 2023 at 11:23:17AM +0100, Marc Zyngier wrote:
> On Sat, 17 Jun 2023 10:08:10 +0100,
> Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Fri, Jun 16, 2023 at 3:53 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
(...)
> > > - /* Some drivers provide custom irqdomain ops */
> > > gc->irq.domain = irq_domain_create_simple(fwnode,
> > > gc->ngpio,
> > > gc->irq.first,
> > > - gc->irq.domain_ops ?: &gpiochip_domain_ops,
> > > + &gpiochip_domain_ops,
> >
> > We better run this by Marc Zyngier, and Thierry who introduced it.
> >
> > But some grepping and looking seems to conclude you are righ!
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> No objection from my end. If this is unused, let's kill it.
Grepping by two independent people and so far no complains from CI, I believe
the patch tells truth.
> Acked-by: Marc Zyngier <maz@kernel.org>
Thank you!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-19 10:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 13:53 [PATCH v1 1/1] gpiolib: Drop unused domain_ops memeber of GPIO IRQ chip Andy Shevchenko
2023-06-17 9:08 ` Linus Walleij
2023-06-17 10:23 ` Marc Zyngier
2023-06-19 10:41 ` Andy Shevchenko [this message]
2023-06-19 13:01 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJAw507ODTUX2elD@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).