From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1316CEB64D7 for ; Mon, 26 Jun 2023 11:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbjFZLNy (ORCPT ); Mon, 26 Jun 2023 07:13:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbjFZLNx (ORCPT ); Mon, 26 Jun 2023 07:13:53 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98876EE; Mon, 26 Jun 2023 04:13:51 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="361283944" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="361283944" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 04:13:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="716096630" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="716096630" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 26 Jun 2023 04:13:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qDkAD-006kCY-1H; Mon, 26 Jun 2023 14:13:45 +0300 Date: Mon, 26 Jun 2023 14:13:45 +0300 From: "andy@kernel.org" To: YE Chengfeng Cc: Kent Gibson , "linus.walleij@linaro.org" , "brgl@bgdev.pl" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] gpio: gpiolib-cdev: Fix potential &lr->wait.lock deadlock issue Message-ID: References: <3C977550-9829-4A6F-A5CA-04C938D77693@connect.ust.hk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3C977550-9829-4A6F-A5CA-04C938D77693@connect.ust.hk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jun 26, 2023 at 10:38:53AM +0000, YE Chengfeng wrote: > > 1) do you have any warning/oops/etc to show the real case? > > 2) shouldn't we annotate with respective lockdep asserts this code? > The bugs were detected by an experimental static code analyzer that I am > implementing. I don't have input to trigger it, so I manually review the > report and then send the ones I believe to be true to you. Perhaps next > time I should mention this while sending the patch. This you have to mention in the submission. https://docs.kernel.org/process/researcher-guidelines.html -- With Best Regards, Andy Shevchenko