From: Kent Gibson <warthog618@gmail.com>
To: Erik Schilling <erik.schilling@linaro.org>
Cc: Linux-GPIO <linux-gpio@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH libgpiod 4/4] bindings: rust: clippy: silence false-positive on iterator
Date: Sat, 1 Jul 2023 21:10:42 +0800 [thread overview]
Message-ID: <ZKAl0pZ3UP7mRk4D@sol> (raw)
In-Reply-To: <CTPXGBYT71JR.290ZDBVD3EMM7@fedora>
On Fri, Jun 30, 2023 at 12:53:36PM +0200, Erik Schilling wrote:
> On Fri Jun 30, 2023 at 12:50 PM CEST, Kent Gibson wrote:
> > On Fri, Jun 30, 2023 at 12:46:11PM +0200, Erik Schilling wrote:
> > > On Fri Jun 30, 2023 at 12:19 PM CEST, Kent Gibson wrote:
> > > > >
> > > >
> > > > That is the only test failing out of the whole suite, so gpiosim is not
> > > > the problem.
> > > >
> > > > That is with the latest from the Raspberry Pi rpi-6.4.y branch[1]
> > > > (a867309b7a55 so a few days old now), with CONFIG_GPIO_SIM so that I can
> > > > run the tests.
> > > > Happens to be running on a Pi ZeroW, but I don't think that test is speed
> > > > sensitive. I have done a complete rebuild - same result.
> > > >
> > > > Are there any distos enabling GPIO_SIM yet?
> > >
> > > Fedora does now (after I asked for it [2]). But it does not support any
> > > 32-bit ARM targets anymore :/. Can you try reproducing it without the
> > > patches? I would be surprised if this was related to the patches.
> > >
> >
> > Tried that - same result with libgpiod master.
> > So it is not from your patches.
>
> Thanks for checking! Will try to reproduce it in the next weeks.
>
Seems there was something broken in my build.
I did a clean slate rebuild and now all tests are passing.
Cheers,
Kent.
next prev parent reply other threads:[~2023-07-01 13:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 11:08 [PATCH libgpiod 0/4] bindings: rust: clippy: fixed warnings Erik Schilling
2023-06-29 11:08 ` [PATCH libgpiod 1/4] bindings: rust: clippy: drop unnecessary casts Erik Schilling
2023-06-29 11:09 ` [PATCH libgpiod 2/4] bindings: rust: clippy: silence false-positives on casts Erik Schilling
2023-06-29 11:09 ` [PATCH libgpiod 3/4] bindings: rust: clippy: drop unneeded conversions Erik Schilling
2023-06-29 11:09 ` [PATCH libgpiod 4/4] bindings: rust: clippy: silence false-positive on iterator Erik Schilling
2023-06-30 9:08 ` Kent Gibson
2023-06-30 10:05 ` Erik Schilling
2023-06-30 10:19 ` Kent Gibson
2023-06-30 10:46 ` Erik Schilling
2023-06-30 10:50 ` Kent Gibson
2023-06-30 10:53 ` Erik Schilling
2023-07-01 13:10 ` Kent Gibson [this message]
2023-06-30 6:08 ` [PATCH libgpiod 0/4] bindings: rust: clippy: fixed warnings Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKAl0pZ3UP7mRk4D@sol \
--to=warthog618@gmail.com \
--cc=erik.schilling@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).