From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH] gpiolib: add missing include
Date: Wed, 5 Jul 2023 19:05:49 +0800 [thread overview]
Message-ID: <ZKVOjft+q4FXykwd@sol> (raw)
In-Reply-To: <CAMRc=MfVsayqftsBJcxyotP2Lz-EPzcXWofFBdYuBDSsVjho_g@mail.gmail.com>
On Wed, Jul 05, 2023 at 12:59:19PM +0200, Bartosz Golaszewski wrote:
> On Wed, Jul 5, 2023 at 12:57 PM Kent Gibson <warthog618@gmail.com> wrote:
> >
> > On Wed, Jul 05, 2023 at 09:42:19AM +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > gpiolib.h uses notifiers but doesn't include <linux/notifier.h>.
> > >
> >
> > Fair enough.
> >
> > Reviewed-by: Kent Gibson <warthog618@gmail.com>
> >
> > Same is true for gpiolib-cdev, btw.
> > You want to touch that one up as well?
> >
>
> No, it already includes gpiolib.h.
>
Yeah, but that is indirect, and gpiolib-cdev.c uses struct notifier_block
directly. Doesn't that warrant an explicit include?
Cheers,
Kent.
next prev parent reply other threads:[~2023-07-05 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 7:42 [PATCH] gpiolib: add missing include Bartosz Golaszewski
2023-07-05 10:57 ` Kent Gibson
2023-07-05 10:59 ` Bartosz Golaszewski
2023-07-05 11:05 ` Kent Gibson [this message]
2023-07-05 11:58 ` Bartosz Golaszewski
2023-07-06 9:34 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2025-02-07 8:30 Bartosz Golaszewski
2025-02-07 20:33 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKVOjft+q4FXykwd@sol \
--to=warthog618@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).