* [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call
@ 2023-07-17 12:10 Andrei Coardos
2023-07-17 14:05 ` Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andrei Coardos @ 2023-07-17 12:10 UTC (permalink / raw)
To: linux-kernel, linux-gpio
Cc: zhang.lyra, baolin.wang, orsonzhai, andy, brgl, linus.walleij,
Andrei Coardos, Alexandru Ardelean
The platform_set_drvdata() call was never used, ever since the driver was
originally added.
It looks like this copy+paste left-over. Possibly the author copied from a
driver that had this line, but also had a remove hook.
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/gpio/gpio-eic-sprd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index 84352a6f4973..53db88ae2a20 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev)
return ret;
}
- platform_set_drvdata(pdev, sprd_eic);
return 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call
2023-07-17 12:10 [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call Andrei Coardos
@ 2023-07-17 14:05 ` Andy Shevchenko
2023-07-20 6:39 ` Baolin Wang
2023-07-29 14:07 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-07-17 14:05 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-gpio, zhang.lyra, baolin.wang, orsonzhai,
brgl, linus.walleij, Alexandru Ardelean
On Mon, Jul 17, 2023 at 03:10:04PM +0300, Andrei Coardos wrote:
> The platform_set_drvdata() call was never used, ever since the driver was
> originally added.
> It looks like this copy+paste left-over. Possibly the author copied from a
> driver that had this line, but also had a remove hook.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call
2023-07-17 12:10 [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-17 14:05 ` Andy Shevchenko
@ 2023-07-20 6:39 ` Baolin Wang
2023-07-29 14:07 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Baolin Wang @ 2023-07-20 6:39 UTC (permalink / raw)
To: Andrei Coardos, linux-kernel, linux-gpio
Cc: zhang.lyra, orsonzhai, andy, brgl, linus.walleij,
Alexandru Ardelean
On 7/17/2023 8:10 PM, Andrei Coardos wrote:
> The platform_set_drvdata() call was never used, ever since the driver was
> originally added.
> It looks like this copy+paste left-over. Possibly the author copied from a
> driver that had this line, but also had a remove hook.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> drivers/gpio/gpio-eic-sprd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index 84352a6f4973..53db88ae2a20 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev)
> return ret;
> }
>
> - platform_set_drvdata(pdev, sprd_eic);
> return 0;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call
2023-07-17 12:10 [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-17 14:05 ` Andy Shevchenko
2023-07-20 6:39 ` Baolin Wang
@ 2023-07-29 14:07 ` Bartosz Golaszewski
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2023-07-29 14:07 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-gpio, zhang.lyra, baolin.wang, orsonzhai,
andy, linus.walleij, Alexandru Ardelean
On Mon, Jul 17, 2023 at 2:10 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> The platform_set_drvdata() call was never used, ever since the driver was
> originally added.
> It looks like this copy+paste left-over. Possibly the author copied from a
> driver that had this line, but also had a remove hook.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/gpio/gpio-eic-sprd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index 84352a6f4973..53db88ae2a20 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -653,7 +653,6 @@ static int sprd_eic_probe(struct platform_device *pdev)
> return ret;
> }
>
> - platform_set_drvdata(pdev, sprd_eic);
> return 0;
> }
>
> --
> 2.34.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-29 14:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 12:10 [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-17 14:05 ` Andy Shevchenko
2023-07-20 6:39 ` Baolin Wang
2023-07-29 14:07 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).