From: Andy Shevchenko <andy@kernel.org>
To: Zhu Wang <wangzhu9@huawei.com>
Cc: nandor.han@ge.com, linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH -next v2] gpio: xra1403: remove redundant of_match_ptr()
Date: Wed, 2 Aug 2023 17:49:01 +0300 [thread overview]
Message-ID: <ZMps3XUiqEwDVO7S@smile.fi.intel.com> (raw)
In-Reply-To: <20230802040232.182535-1-wangzhu9@huawei.com>
On Wed, Aug 02, 2023 at 12:02:32PM +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> of_match_ptr() here, and __maybe_unused can also be removed.
>
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.
> Since spi.h included mod_devicetable.h, so we drop mod_devicetable.h.
Okay, but it's other way around, "we don't include it if it was missing".
Sorry, I was probably unclear about this. Here it's fine and good that
it's included explicitly, no need to drop.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-02 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 4:02 [PATCH -next v2] gpio: xra1403: remove redundant of_match_ptr() Zhu Wang
2023-08-02 14:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMps3XUiqEwDVO7S@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=nandor.han@ge.com \
--cc=wangzhu9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox