From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A76C41513 for ; Thu, 17 Aug 2023 16:28:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352300AbjHQQ1p (ORCPT ); Thu, 17 Aug 2023 12:27:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353665AbjHQQ1R (ORCPT ); Thu, 17 Aug 2023 12:27:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62DEE35AD for ; Thu, 17 Aug 2023 09:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692289576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EZk7pCD0HPe+ABrfYsTMs6MpHKEmTin7ICiAaY/ju7w=; b=Ufd0IMVlLI1+anV0BzbY5a8Je75dLfVU8Uev167p11nFs6WiH93DLtkRwl2Hx5nD+vF/Wc NvtMDhr8DYhh5LpmoG9bYCxui8ZdeWqcDnN85GoKGSQaSv4uBJf4o1AoSsf5HM5merduWL dm1zLbfZ/LdcS4SMwGsDrxeR8/MaEMo= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-rGpvZSzPP8q7H21hHVhn9g-1; Thu, 17 Aug 2023 12:26:13 -0400 X-MC-Unique: rGpvZSzPP8q7H21hHVhn9g-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-589f986ab8aso10817b3.1 for ; Thu, 17 Aug 2023 09:26:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692289573; x=1692894373; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EZk7pCD0HPe+ABrfYsTMs6MpHKEmTin7ICiAaY/ju7w=; b=LzsnE8D3F0ZjgxmcUGTPgczvOwVi3YNtF3Aim2QZAJg5cliFwiOjJGDYH21E18VJP+ JDdLb96dJKD0ArmLnvxZPPGDZh+MF7MBBfQO3/pl8LzGpSU5Rg/Ku0pFkQawZi5il+nD D1cCJ78Y4VGGuN+B7uKn5Ygmd8PdIxXRsAalLnmRuZsQ+yvPBLKohWQ9TXkZfsPjQjAc BOLusVMRnn5nbcq10UmZJoqJ3fsNWWfl69Unevmv3fBw3hZ2SG5LXQTdOgbqd+Iynqfr Hqp3PgCdnieu/qObRZ/X2erMjtRCoB02pXP0jyI1By8evZWcEgHsuBF3ygcpQkqxqtFc CnXw== X-Gm-Message-State: AOJu0YytQlsg+h00Kb2/NeWZwlWAdqk17dbjz2SvLuH6OPUgvsmdQqAi N0AjvUvafJDyI8TMm6H0Cje8OrRZmNP3BTEM+zC8COFCMWWZh1vPVv+woMncB9Cg1ZjJuYoC7g+ x9ExRcJ3N7x4kpH7nlJXxaw== X-Received: by 2002:a81:9289:0:b0:581:7958:5bda with SMTP id j131-20020a819289000000b0058179585bdamr4117560ywg.1.1692289572679; Thu, 17 Aug 2023 09:26:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFDMsUg7Qvc0ShK/beubOLSc6c6/DQghAOnIqHeSrnHVzvTsNVwwDg01IycrQ1PQJjVGdmfg== X-Received: by 2002:a81:9289:0:b0:581:7958:5bda with SMTP id j131-20020a819289000000b0058179585bdamr4117535ywg.1.1692289572426; Thu, 17 Aug 2023 09:26:12 -0700 (PDT) Received: from brian-x1 (c-73-214-169-22.hsd1.pa.comcast.net. [73.214.169.22]) by smtp.gmail.com with ESMTPSA id y8-20020a0dd608000000b00589e84acafasm1079736ywd.48.2023.08.17.09.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 09:26:11 -0700 (PDT) Date: Thu, 17 Aug 2023 12:26:10 -0400 From: Brian Masney To: Konrad Dybcio Cc: andersson@kernel.org, linus.walleij@linaro.org, agross@kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: qcom-pmic-gpio: silence -EPROBE_DEFER message on probe Message-ID: References: <20230817145941.1091418-1-bmasney@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Aug 17, 2023 at 05:01:19PM +0200, Konrad Dybcio wrote: > On 17.08.2023 16:59, Brian Masney wrote: > > The following message shows up one or more times when booting a Qualcomm > > SA8775 Development board: > > > > qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: can't add gpio chip > > > > Convert this over to use dev_err_probe() to silence this message. > > > > Signed-off-by: Brian Masney > > --- > That looks odd, why would it ever defer? > > SPMI should be up by the time it gets a chance to probe. You replied within the same minute of me posting that patch, which is the fastest review I've had to date on an upstream kernel list. Before we continue, please verify: [ ] I am not a robot :) So SPMI is up and probes normally the first time, and is up by time this driver probes. I think the probe deferral is happening somewhere in pinctrl, however I am not sure exactly where. I added some tracers to the kernel command line and here's some relevant log messages: device: 'c440000.spmi:pmic@2:gpio@8800': device_add bus: 'platform': add device c440000.spmi:pmic@2:gpio@8800 PM: Adding info for platform:c440000.spmi:pmic@2:gpio@8800 bus: 'platform': __driver_probe_device: matched device c440000.spmi:pmic@2:gpio@8800 with driver qcom-spmi-gpio bus: 'platform': really_probe: probing driver qcom-spmi-gpio with device c440000.spmi:pmic@2:gpio@8800 qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: no pinctrl handle qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: try to register 12 pins ... pinctrl core: registered pin 0 (gpio1) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 1 (gpio2) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 2 (gpio3) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 3 (gpio4) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 4 (gpio5) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 5 (gpio6) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 6 (gpio7) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 7 (gpio8) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 8 (gpio9) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 9 (gpio10) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 10 (gpio11) on c440000.spmi:pmic@2:gpio@8800 pinctrl core: registered pin 11 (gpio12) on c440000.spmi:pmic@2:gpio@8800 qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: no hogs found qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: error -EPROBE_DEFER: can't add gpio chip qcom-spmi-gpio c440000.spmi:pmic@2:gpio@8800: Driver qcom-spmi-gpio requests probe deferral platform c440000.spmi:pmic@2:gpio@8800: Added to deferred list The second time it probes the device is successfully added. Brian