From: Kent Gibson <warthog618@gmail.com>
To: andy pugh <bodgesoc@gmail.com>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [libgpiod] gpiod_line_get_value_bulk may be broken?
Date: Fri, 11 Aug 2023 09:36:49 +0800 [thread overview]
Message-ID: <ZNWQsabr8kPCbD4X@sol> (raw)
In-Reply-To: <CAN1+YZWTJ-TqjR99MBGSPPmQY1ao-TCGu-DfNTYBQvbXcmV=5A@mail.gmail.com>
On Fri, Aug 11, 2023 at 02:26:55AM +0100, andy pugh wrote:
> On Fri, 11 Aug 2023 at 01:59, Kent Gibson <warthog618@gmail.com> wrote:
>
> > So you don't need to alloc for it at all - gpiod_line_find() already did
> > that. As per that function's comment, you still need to close the chip
> > eventually to prevent memory leaks.
>
> Close then free?
>
gpiod_chip_close() does both the close of the file descriptor and the free
of the allocated struct.
Cheers,
Kent.
next prev parent reply other threads:[~2023-08-11 1:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 15:14 [libgpiod] gpiod_line_get_value_bulk may be broken? andy pugh
2023-07-27 20:53 ` Kent Gibson
2023-07-27 21:17 ` andy pugh
2023-07-27 21:55 ` Kent Gibson
2023-07-27 22:10 ` andy pugh
2023-07-27 22:36 ` Kent Gibson
2023-07-28 0:39 ` andy pugh
2023-07-28 1:07 ` andy pugh
2023-07-28 5:57 ` Kent Gibson
2023-07-28 19:01 ` andy pugh
2023-07-29 2:03 ` Kent Gibson
2023-08-05 22:55 ` andy pugh
2023-08-06 1:02 ` Kent Gibson
2023-08-06 9:13 ` andy pugh
2023-08-06 9:29 ` Kent Gibson
2023-08-10 0:17 ` andy pugh
2023-08-10 0:46 ` Kent Gibson
2023-08-10 22:07 ` andy pugh
2023-08-11 0:59 ` Kent Gibson
2023-08-11 1:26 ` andy pugh
2023-08-11 1:36 ` Kent Gibson [this message]
2023-08-14 22:25 ` How to use gpiod_line_set_flags andy pugh
2023-08-15 0:49 ` Kent Gibson
2023-08-15 18:03 ` andy pugh
2023-08-11 12:19 ` [libgpiod] gpiod_line_get_value_bulk may be broken? Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNWQsabr8kPCbD4X@sol \
--to=warthog618@gmail.com \
--cc=bodgesoc@gmail.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).