From: andy.shevchenko@gmail.com
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
stable@kernel.org, Chris Paterson <Chris.Paterson2@renesas.com>
Subject: Re: [PATCH 1/3] pinctrl: renesas: rzg2l: Fix NULL pointer dereference in rzg2l_dt_subnode_to_map()
Date: Mon, 14 Aug 2023 23:49:10 +0300 [thread overview]
Message-ID: <ZNqTRrf2iC6xLvR7@surfacebook.localdomain> (raw)
In-Reply-To: <20230814072436.3757-2-biju.das.jz@bp.renesas.com>
Mon, Aug 14, 2023 at 08:24:34AM +0100, Biju Das kirjoitti:
> Fix the below random NULL pointer crash during boot by serializing
> pinctrl group and function creation/remove calls in
> rzg2l_dt_subnode_to_map() with mutex lock.
> Crash logs:
> [ 15.310036] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
> [ 15.354291] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
> [ 15.870714] [0000000000000000] pgd=0000000000000000, p4d=0000000000000000
> [ 15.939989] Internal error: Oops: 0000000096000004 2 PREEMPT SMP
> [ 15.946285] Modules linked in: drm_shmem_helper rzg2l_mipi_dsi videobuf2_common display_connector gpu_sched mc drm_kms_helper rcar_fcp drm rcar_canfd snd_soc_wm8978 rtc_isl1208 can_dev rzg2l_adc snd_soc_rz_ssi renesas_rpc_if spi_rspi backlight ipv6
> [ 15.969077] CPU: 1 PID: 117 Comm: systemd-udevd Tainted: G D 6.5.0-rc4-next-20230801-00013-gd1819ab30a54 #986
> [ 15.980351] Hardware name: Renesas SMARC EVK based on r9a07g054l2 (DT)
> [ 15.986857] pstate: 40400005 (nZcv daif +PAN UAO -TCO -DIT -SSBS BTYPE=-)
> [ 15.993797] pc : __pi_strcmp+0x20/0x140
> [ 15.997647] lr : pinmux_func_name_to_selector+0x68/0xa4
> [ 16.002876] sp : ffff800082d9b5a0
> [ 16.006210] x29: ffff800082d9b5a0 x28: 0000000000000002 x27: ffff00000cda7080
> [ 16.013338] x26: 0000000000000002 x25: ffff00000a1f26c0 x24: ffff00000cda7080
> [ 16.020456] x23: ffff800081224960 x22: ffff00007fc2e598 x21: 000000000000000c
> [ 16.027571] x20: ffff00000b6c8840 x19: 000000000000000b x18: 0000000000000002
> [ 16.034686] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000
> [ 16.041799] x14: 0000000000000001 x13: 0000000000068a68 x12: 0000000000000040
> [ 16.048913] x11: ffff00000b092ff8 x10: 0000ffff803d1a68 x9 : ffff00000b6c8888
> [ 16.056028] x8 : 0101010101010101 x7 : 0000000000000000 x6 : 0000000000000000
> [ 16.063142] x5 : ffff00000b092ff8 x4 : ffff00000b093078 x3 : 0000000000000000
> [ 16.070256] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff00007fc2e598
> [ 16.077370] Call trace:
> [ 16.079807] __pi_strcmp+0x20/0x140
> [ 16.083296] pinmux_generic_add_function+0x34/0xcc
> [ 16.088077] rzg2l_dt_subnode_to_map+0x314/0x44c
> [ 16.092682] rzg2l_dt_node_to_map+0x164/0x194
> [ 16.097025] pinctrl_dt_to_map+0x218/0x37c
> [ 16.101107] create_pinctrl+0x70/0x3d8
Submitting Patches says why the above is too noisy for the commit message.
Please, amend accordingly.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-14 20:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 7:24 [PATCH 0/3] Fix NULL pointer dereference in RZ/{G2L,V2M,A2} pinctrl driver Biju Das
2023-08-14 7:24 ` [PATCH 1/3] pinctrl: renesas: rzg2l: Fix NULL pointer dereference in rzg2l_dt_subnode_to_map() Biju Das
2023-08-14 20:49 ` andy.shevchenko [this message]
2023-08-15 6:44 ` Biju Das
2023-08-15 9:14 ` Linus Walleij
2023-08-15 9:32 ` Geert Uytterhoeven
2023-08-15 11:46 ` Linus Walleij
2023-08-14 7:24 ` [PATCH 2/3] pinctrl: renesas: rzv2m: Fix NULL pointer dereference in rzv2m_dt_subnode_to_map() Biju Das
2023-08-14 20:49 ` andy.shevchenko
2023-08-14 7:24 ` [PATCH 3/3] pinctrl: renesas: rza2: Add lock around pinctrl_generic{{add,remove}_group,{add,remove}_function} Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNqTRrf2iC6xLvR7@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox