From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DCEEE49A6 for ; Mon, 21 Aug 2023 17:00:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232276AbjHURAf (ORCPT ); Mon, 21 Aug 2023 13:00:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231397AbjHURAf (ORCPT ); Mon, 21 Aug 2023 13:00:35 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82F0010F; Mon, 21 Aug 2023 10:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692637218; x=1724173218; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=n7S/UFEeowdzIZmbsuVfPC9j0Vf3rJq/KFb1fvy2s7A=; b=m0OiH4fvmlXCOg8qHcR9OuNUs9bOoFVFdJYAIS7UGNVK78ZYJfh6nUB3 n2r7Ri4anQbzS9BO7vhJ8LSkgSQomGbopYrcO+k+3V6hS8LIalT1hXWnq M7rtqTqDL62hdjPTIZtiCk08u2I7cCEDoQZp84YqyPGXVoAeVeV7LPu58 L7WdVhdF/DaFx1GUxRygbxu2eYCYBwa5gkBqwFfbNb9E3FHqGxdcG8g47 7gMxp2sEaps5mahBLHsLflERFcrmqwdvatsIS6OXyJNP9hpxO4VjKpjdP 14NS/ZvFwTj60kQzVpEC3EQa/y8lOKMB/4lYhVIBqO/uX0HY8cFVkoJ2c w==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="372546682" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="372546682" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 10:00:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="826004434" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="826004434" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 21 Aug 2023 10:00:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qY8G7-005X2E-2I; Mon, 21 Aug 2023 20:00:07 +0300 Date: Mon, 21 Aug 2023 20:00:07 +0300 From: Andy Shevchenko To: Mika Westerberg , Linus Walleij , Balsam CHIHI , Claudiu Beznea , Geert Uytterhoeven , Wolfram Sang , Thierry Reding , Paul Cercueil , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org Cc: Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Ludovic Desroches , Nicolas Ferre , Alexandre Belloni , Jonathan Hunter , "Rafael J. Wysocki" , Len Brown , Pavel Machek Subject: Re: [PATCH v2 00/10] pinctrl: Provide NOIRQ PM helper and use it Message-ID: References: <20230717172821.62827-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717172821.62827-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jul 17, 2023 at 08:28:11PM +0300, Andy Shevchenko wrote: > Intel pin control drivers use NOIRQ variant of the PM callbacks. > Besides that several other drivers do similar. Provide a helper > to make them smaller and less error prone against different > kernel configurations (with possible defined but not used variables). > > The idea is to have an immutable branch that PM tree can pull as well as > main pin control one. We also can do other way around, if Rafael prefers > that. I have partially applied the series to my review and testing queue with the following changes (besides the tags added): - split pm_ptr() patches to be first with lynxpoint commit message updated - fixed wording in the pm.h comment - amended cherryview to wrap long line - explained __maybe_unused and pm_ptr() changes in at91 commit message - added pm_sleep_ptr() and explained that in the tegra commit message - renesas and mvebu went as is - intel and mediatek left aside for better rework drivers/pinctrl/intel/pinctrl-baytrail.c | 11 +++-------- drivers/pinctrl/intel/pinctrl-cherryview.c | 10 +++------- drivers/pinctrl/intel/pinctrl-lynxpoint.c | 7 +++---- drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 14 +++----------- drivers/pinctrl/pinctrl-at91.c | 10 ++++------ drivers/pinctrl/renesas/core.c | 16 +++++++--------- drivers/pinctrl/tegra/pinctrl-tegra.c | 5 +---- drivers/pinctrl/tegra/pinctrl-tegra210.c | 2 +- include/linux/pm.h | 9 +++++++++ 9 files changed, 34 insertions(+), 50 deletions(-) -- With Best Regards, Andy Shevchenko