* [PATCH] pinctrl: berlin: Drop superfluous ampersands
@ 2023-08-24 10:05 Geert Uytterhoeven
2023-08-27 10:21 ` Jisheng Zhang
2023-09-11 13:45 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-08-24 10:05 UTC (permalink / raw)
To: Linus Walleij, Jisheng Zhang, Sebastian Hesselbarth,
Antoine Tenart
Cc: linux-gpio, linux-arm-kernel, Geert Uytterhoeven
There is no need to use an ampersand to take the address of a function.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/berlin/berlin.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c
index 1e427ea4d31bcbfc..9550cc8095c28720 100644
--- a/drivers/pinctrl/berlin/berlin.c
+++ b/drivers/pinctrl/berlin/berlin.c
@@ -96,10 +96,10 @@ static int berlin_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrl_dev,
}
static const struct pinctrl_ops berlin_pinctrl_ops = {
- .get_groups_count = &berlin_pinctrl_get_group_count,
- .get_group_name = &berlin_pinctrl_get_group_name,
- .dt_node_to_map = &berlin_pinctrl_dt_node_to_map,
- .dt_free_map = &pinctrl_utils_free_map,
+ .get_groups_count = berlin_pinctrl_get_group_count,
+ .get_group_name = berlin_pinctrl_get_group_name,
+ .dt_node_to_map = berlin_pinctrl_dt_node_to_map,
+ .dt_free_map = pinctrl_utils_free_map,
};
static int berlin_pinmux_get_functions_count(struct pinctrl_dev *pctrl_dev)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: berlin: Drop superfluous ampersands
2023-08-24 10:05 [PATCH] pinctrl: berlin: Drop superfluous ampersands Geert Uytterhoeven
@ 2023-08-27 10:21 ` Jisheng Zhang
2023-09-11 13:45 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2023-08-27 10:21 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Walleij, Sebastian Hesselbarth, Antoine Tenart, linux-gpio,
linux-arm-kernel
On Thu, Aug 24, 2023 at 12:05:50PM +0200, Geert Uytterhoeven wrote:
> There is no need to use an ampersand to take the address of a function.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Jisheng Zhang <jszhang@kernel.org>
Hi Linus Walleij,
If it's not too late, could you please merge it?
Thanks in advance
> ---
> drivers/pinctrl/berlin/berlin.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c
> index 1e427ea4d31bcbfc..9550cc8095c28720 100644
> --- a/drivers/pinctrl/berlin/berlin.c
> +++ b/drivers/pinctrl/berlin/berlin.c
> @@ -96,10 +96,10 @@ static int berlin_pinctrl_dt_node_to_map(struct pinctrl_dev *pctrl_dev,
> }
>
> static const struct pinctrl_ops berlin_pinctrl_ops = {
> - .get_groups_count = &berlin_pinctrl_get_group_count,
> - .get_group_name = &berlin_pinctrl_get_group_name,
> - .dt_node_to_map = &berlin_pinctrl_dt_node_to_map,
> - .dt_free_map = &pinctrl_utils_free_map,
> + .get_groups_count = berlin_pinctrl_get_group_count,
> + .get_group_name = berlin_pinctrl_get_group_name,
> + .dt_node_to_map = berlin_pinctrl_dt_node_to_map,
> + .dt_free_map = pinctrl_utils_free_map,
> };
>
> static int berlin_pinmux_get_functions_count(struct pinctrl_dev *pctrl_dev)
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: berlin: Drop superfluous ampersands
2023-08-24 10:05 [PATCH] pinctrl: berlin: Drop superfluous ampersands Geert Uytterhoeven
2023-08-27 10:21 ` Jisheng Zhang
@ 2023-09-11 13:45 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-09-11 13:45 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Jisheng Zhang, Sebastian Hesselbarth, Antoine Tenart, linux-gpio,
linux-arm-kernel
On Thu, Aug 24, 2023 at 12:05 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> There is no need to use an ampersand to take the address of a function.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied as nonurgent fix.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-11 21:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24 10:05 [PATCH] pinctrl: berlin: Drop superfluous ampersands Geert Uytterhoeven
2023-08-27 10:21 ` Jisheng Zhang
2023-09-11 13:45 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).