From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 067FECA0EC0 for ; Mon, 11 Sep 2023 20:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239877AbjIKUzc (ORCPT ); Mon, 11 Sep 2023 16:55:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236166AbjIKJwD (ORCPT ); Mon, 11 Sep 2023 05:52:03 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6143FE4E; Mon, 11 Sep 2023 02:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694425919; x=1725961919; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6VFTFuruN2uSMZ2HAV5yoTE1QyK+PLotHbOXUJ4WTbA=; b=YcXbmYM1Dk5P5E/UUv+pm1Yv4923qV3/5gI/le4znCn51oY+AZrqo0J9 Dfllj0TjUb4d4fflgE67aV9Y40vIwfTm3FPhKB2uhydD5vyNvBy63wKNa 8AmtIc86k1PNSYMhVjKsXPss+BkzwNBNWiCB48cZnl4qHSAWbT7fdKIQW BA3UXivNGIBFCZ9sKUZszKK7DhqhQbtzwqelsYSIHZHUN2xRf8s7tgKO3 peUsreRywuEK/sQh+41lVpxuuoo+6xHBAFfczY+jEa9wz3i6qma6URmbu x9cm6VcV3752sdypvrXyBqsjSDetegWKSdwuNaWRfvWpyPurcYsBZFtnY Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="444457583" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="444457583" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 02:51:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10829"; a="833443698" X-IronPort-AV: E=Sophos;i="6.02,243,1688454000"; d="scan'208";a="833443698" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2023 02:51:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qfdaD-008Hbv-0b; Mon, 11 Sep 2023 12:51:53 +0300 Date: Mon, 11 Sep 2023 12:51:52 +0300 From: Andy Shevchenko To: Linhua Xu Cc: Linus Walleij , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, lh xu , Zhirong Qiu , Xiongpeng Wu Subject: Re: [PATCH V2 3/6] pinctrl: sprd: Modify pull-up parameters Message-ID: References: <20230908055146.18347-1-Linhua.xu@unisoc.com> <20230908055146.18347-4-Linhua.xu@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908055146.18347-4-Linhua.xu@unisoc.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Sep 08, 2023 at 01:51:43PM +0800, Linhua Xu wrote: > From: Linhua Xu > > For UNISOC pin controller, there are three different configurations of > pull-up drive current. Modify the 20K pull-up resistor configuration and > add the 1.8K pull-up resistor configuration. ... > -#define PULL_UP_4_7K (BIT(12) | BIT(7)) > +#define PULL_UP_1_8K (BIT(12) | BIT(7)) > +#define PULL_UP_4_7K BIT(12) This looks like a real fix, please add Fixes tag and move the patch to be the first in the series. -- With Best Regards, Andy Shevchenko