From: Andi Shyti <andi.shyti@linux.intel.com>
To: Wentong Wu <wentong.wu@intel.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de, mka@chromium.org,
oneukum@suse.com, lee@kernel.org, wsa@kernel.org,
kfting@nuvoton.com, broonie@kernel.org, linus.walleij@linaro.org,
maz@kernel.org, brgl@bgdev.pl, linux-usb@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
linux-gpio@vger.kernel.org, andriy.shevchenko@linux.intel.com,
heikki.krogerus@linux.intel.com, andi.shyti@linux.intel.com,
sakari.ailus@linux.intel.com, bartosz.golaszewski@linaro.org,
srinivas.pandruvada@intel.com, zhifeng.wang@intel.com
Subject: Re: [PATCH v12 4/4] gpio: update Intel LJCA USB GPIO driver
Date: Fri, 1 Sep 2023 17:18:50 +0200 [thread overview]
Message-ID: <ZPIA2mMtNRakNqqd@ashyti-mobl2.lan> (raw)
In-Reply-To: <1693546577-17824-5-git-send-email-wentong.wu@intel.com>
Hi Wentong,
On Fri, Sep 01, 2023 at 01:36:17PM +0800, Wentong Wu wrote:
> This driver communicate with LJCA GPIO module with specific
> protocol through interfaces exported by LJCA USB driver.
> Update the driver according to LJCA USB driver's changes.
>
> Signed-off-by: Wentong Wu <wentong.wu@intel.com>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
I am not understanding this patch... Looks like a collection of
random to relevant changes you did in gpio-ljca.c.
I'm not able to review this, can you please split it in minor
changes?
Meanwhile the previous patches should be able to work without
this one, right?
Andi
next prev parent reply other threads:[~2023-09-01 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 5:36 [PATCH v12 0/4] Add Intel LJCA device driver Wentong Wu
2023-09-01 5:36 ` [PATCH v12 1/4] usb: Add support for Intel LJCA device Wentong Wu
2023-09-01 15:04 ` Andi Shyti
2023-09-02 17:17 ` Wu, Wentong
2023-09-01 5:36 ` [PATCH v12 2/4] i2c: Add support for Intel LJCA USB I2C driver Wentong Wu
2023-09-02 18:19 ` Andi Shyti
2023-09-13 8:44 ` Wolfram Sang
2023-09-01 5:36 ` [PATCH v12 3/4] spi: Add support for Intel LJCA USB SPI driver Wentong Wu
2023-09-01 15:12 ` Andi Shyti
2023-09-02 17:17 ` Wu, Wentong
2023-09-01 5:36 ` [PATCH v12 4/4] gpio: update Intel LJCA USB GPIO driver Wentong Wu
2023-09-01 15:18 ` Andi Shyti [this message]
2023-09-02 17:29 ` Wu, Wentong
2023-09-02 18:14 ` Andi Shyti
2023-09-02 14:58 ` [PATCH v12 0/4] Add Intel LJCA device driver Hans de Goede
2023-09-02 17:15 ` Wu, Wentong
2023-09-02 19:00 ` Hans de Goede
2023-09-03 14:38 ` Wu, Wentong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPIA2mMtNRakNqqd@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfting@nuvoton.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mka@chromium.org \
--cc=oneukum@suse.com \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@intel.com \
--cc=wentong.wu@intel.com \
--cc=wsa@kernel.org \
--cc=zhifeng.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).