From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v3] gpio: sim: don't fiddle with GPIOLIB private members
Date: Tue, 5 Sep 2023 15:08:54 +0300 [thread overview]
Message-ID: <ZPcaVjOudGeLd5EP@smile.fi.intel.com> (raw)
In-Reply-To: <ZPcZfd5UtzMmIUvm@smile.fi.intel.com>
On Tue, Sep 05, 2023 at 03:05:17PM +0300, Andy Shevchenko wrote:
> On Tue, Sep 05, 2023 at 10:24:13AM +0200, Bartosz Golaszewski wrote:
...
> > + chip->swnode = swnode;
> > + ret = device_for_each_child(dev, chip, gpio_sim_chip_set_device);
> > + if (!ret)
> > + return -ENODEV;
>
> Can bus_find_device_by_fwnode() be used here?
Answering to myself: you already mentioned that this should cover any bus,
so the answer is "no".
But also we have device_find_child() if I understood the purpose of the above
it should suit better, no?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-05 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 8:24 [PATCH v3] gpio: sim: don't fiddle with GPIOLIB private members Bartosz Golaszewski
2023-09-05 12:05 ` Andy Shevchenko
2023-09-05 12:08 ` Andy Shevchenko [this message]
2023-09-05 12:10 ` Bartosz Golaszewski
2023-09-05 12:35 ` Andy Shevchenko
2023-09-05 12:09 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPcaVjOudGeLd5EP@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).