From: Andy Shevchenko <andy@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [RFT PATCH 2/3] gpio: eic-sprd: use a helper variable for &pdev->dev
Date: Tue, 12 Sep 2023 13:35:27 +0300 [thread overview]
Message-ID: <ZQA+716X8EVmIRAt@smile.fi.intel.com> (raw)
In-Reply-To: <20230912094519.22769-2-brgl@bgdev.pl>
On Tue, Sep 12, 2023 at 11:45:18AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Instead of dereferencing pdev everywhere, just store the address of the
> underlying struct device in a local variable.
...
> - return devm_add_action_or_reset(&pdev->dev,
> - sprd_eic_unregister_notifier,
> + return devm_add_action_or_reset(dev, sprd_eic_unregister_notifier,
> &sprd_eic->irq_nb);
Ping-pong style detected: Lines added / modified by previous patch in the same
series got modified again.
If you look at how I do that, I introduce the temporary variable with my new
code and then reuse it later on.
OTOH, I see that the first one is supposed to be backported (?) in such case
perhaps it's fine.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-12 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 9:45 [RFT PATCH 1/3] gpio: eic-sprd: unregister from the irq notifier on remove() Bartosz Golaszewski
2023-09-12 9:45 ` [RFT PATCH 2/3] gpio: eic-sprd: use a helper variable for &pdev->dev Bartosz Golaszewski
2023-09-12 10:07 ` Baolin Wang
2023-09-12 10:35 ` Andy Shevchenko [this message]
2023-09-12 11:23 ` Bartosz Golaszewski
2023-09-12 9:45 ` [RFT PATCH 3/3] gpio: eic-sprd: use devm_platform_ioremap_resource() Bartosz Golaszewski
2023-09-12 10:05 ` Baolin Wang
2023-09-12 10:09 ` Bartosz Golaszewski
2023-09-12 11:07 ` Baolin Wang
2023-09-12 10:37 ` Andy Shevchenko
2023-09-12 11:02 ` [RFT PATCH 1/3] gpio: eic-sprd: unregister from the irq notifier on remove() Baolin Wang
2023-09-13 12:14 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQA+716X8EVmIRAt@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).