From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC705E7B604 for ; Wed, 4 Oct 2023 12:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233223AbjJDMpu (ORCPT ); Wed, 4 Oct 2023 08:45:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233088AbjJDMpu (ORCPT ); Wed, 4 Oct 2023 08:45:50 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AB87A6; Wed, 4 Oct 2023 05:45:46 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="380434375" X-IronPort-AV: E=Sophos;i="6.03,200,1694761200"; d="scan'208";a="380434375" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 05:45:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="751266672" X-IronPort-AV: E=Sophos;i="6.03,200,1694761200"; d="scan'208";a="751266672" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 05:45:21 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC1) (envelope-from ) id 1qo1Fg-00000002lzt-0GOm; Wed, 04 Oct 2023 15:45:20 +0300 Date: Wed, 4 Oct 2023 15:45:19 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 30/36] pinctrl: remove old GPIO helpers Message-ID: References: <20231003145114.21637-1-brgl@bgdev.pl> <20231003145114.21637-31-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Oct 04, 2023 at 10:49:25AM +0200, Bartosz Golaszewski wrote: > On Tue, Oct 3, 2023 at 5:21 PM Andy Shevchenko > wrote: > > On Tue, Oct 3, 2023 at 5:51 PM Bartosz Golaszewski wrote: ... > > > Old variants of pinctrl GPIO helpers are no longer used. Let's remove > > > them as well as convert all static functions in pinctrl/core.c that > > > still deal with global GPIO numbers to using the gpio_chip + offset > > > pairs. > > > > This patch does three thighs as I see it. > > > > I'd argue it just fold the code that lived in old functions into the new ones... > > > First of all, it silently converts to RAII. Please, do this separately. > > ... and while at it, it already switches to SBRM because why copy outdated code. This is too big thing for "while at it". If you care about that switch, do it beforehand. But at bare minimum it should be a separate patch. > > Second, it shuffles a lot of code between old and new implementations. > > What I prefer to see is what the subject tells: only "-" (minus) > > lines. > > Third, it will become easier if you name the "new" functions better to > > begin with, it will help a lot here. > > I'll wait for Linus to tell me if he prefers one big squashed commit > or a fine-grained history (I prefer the latter) before spending time > splitting this commit. Definitely, changing code to SBRM is out of scope of this series and should be done in a separate patch at least. -- With Best Regards, Andy Shevchenko