From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45068CE7A81 for ; Mon, 25 Sep 2023 07:34:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbjIYHeh (ORCPT ); Mon, 25 Sep 2023 03:34:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231393AbjIYHeh (ORCPT ); Mon, 25 Sep 2023 03:34:37 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 032DED3; Mon, 25 Sep 2023 00:34:30 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="381096807" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="381096807" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 00:34:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="863766764" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="863766764" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 00:34:09 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qkg6Y-00000000HRL-0NDd; Mon, 25 Sep 2023 10:34:06 +0300 Date: Mon, 25 Sep 2023 10:34:05 +0300 From: Andy Shevchenko To: Duje =?utf-8?Q?Mihanovi=C4=87?= Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Alan Stern , Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH RFC 4/6] ARM: pxa: Convert reset driver to GPIO descriptors Message-ID: References: <20230924-pxa-gpio-v1-0-2805b87d8894@skole.hr> <20230924-pxa-gpio-v1-4-2805b87d8894@skole.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230924-pxa-gpio-v1-4-2805b87d8894@skole.hr> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, Sep 24, 2023 at 06:42:57PM +0200, Duje Mihanović wrote: > The PXA reset driver still uses the legacy GPIO interface for > configuring and asserting the reset pin. > > Convert it to use the GPIO descriptor interface. ... > + reset_gpio = gpiod_get(NULL, "reset generator", GPIOD_ASIS); > + if (IS_ERR(reset_gpio)) { > + printk(KERN_ERR "Can't request reset_gpio: %ld\n", > + PTR_ERR(reset_gpio)); pr_err() > + return PTR_ERR(reset_gpio); > } -- With Best Regards, Andy Shevchenko