From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F47E7E649 for ; Tue, 26 Sep 2023 15:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234866AbjIZP1K (ORCPT ); Tue, 26 Sep 2023 11:27:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234902AbjIZP1J (ORCPT ); Tue, 26 Sep 2023 11:27:09 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C00B1194; Tue, 26 Sep 2023 08:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695742022; x=1727278022; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=EL5E/4NncYmKUL+520Iyp+Uj3MNs/WEgnKcUVFXSP5s=; b=fGEwg8BGqjN7UrxgqyxaQFxsamo511wt+AhVvRylDGS11ZqJxmH7P7Wo a3G1ne2uEBTSHtgD8EBexk7Zaqg2lHbgI5gnSvzMM0HFJgATH9CJOqX/6 Je2c5f0618+cYnq7rEvHWxVLzicEKoWeXlN6zvZkY3mbx+c16oxdHKC5m 1/4J6BY9gtsKilgD0cYyRCngPTChi1JRH5wrrzIkqR67LMhHEBKp98t5Q gRaFAjjxNl+6/WQugEjtQWHVnOfNK0t+jytwuJdN3m0tGrz58RTThY526 La20Q3QR1RMGsbddqJ0riXPmWbRtfXdNtcCpJqS4kESbinUNsFOKdKokt A==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="378871151" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="378871151" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 08:27:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="839060442" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="839060442" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 08:26:57 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1ql9xe-00000000eKO-0NGt; Tue, 26 Sep 2023 18:26:54 +0300 Date: Tue, 26 Sep 2023 18:26:53 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Mika Westerberg , Linus Walleij , Daniel Scally , Hans de Goede , Mark Gross , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski Subject: Re: [RFT PATCH 2/4] platform/x86: int3472: led: don't use gpiod_toggle_active_low() Message-ID: References: <20230926145943.42814-1-brgl@bgdev.pl> <20230926145943.42814-3-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230926145943.42814-3-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Sep 26, 2023 at 04:59:41PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Instead of acpi_get_and_request_gpiod() + gpiod_toggle_active_low(), use > temporary lookup tables with appropriate lookup flags. ... > + int3472->pled.gpio = skl_int3472_gpiod_get_from_temp_lookup( > + int3472->dev, path, agpio->pin_table[0], > + "int3472,privacy-led", polarity, > + GPIOD_OUT_LOW); Personally I found this style weird. I prefer to have longer line over the split on the parentheses. -- With Best Regards, Andy Shevchenko