* [PATCH] pinctrl: tegra: add OF node when logging OF parsing errors
@ 2023-09-26 10:39 Luca Ceresoli
2023-09-26 13:41 ` Thierry Reding
2023-09-27 8:55 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Luca Ceresoli @ 2023-09-26 10:39 UTC (permalink / raw)
To: linux-tegra
Cc: Luca Ceresoli, Linus Walleij, Thierry Reding, Jonathan Hunter,
Andy Shevchenko, Prathamesh Shete, Thierry Reding, linux-gpio,
linux-kernel, Thomas Petazzoni
These errors are not quite clear without also logging they device tree node
being parsed, especially when the pinmux node has lots of subnodes. Adding
the node name helps a lot in finding the node that triggers the error.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/pinctrl/tegra/pinctrl-tegra.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index 734c71ef005b..6bf8db424bec 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -120,7 +120,7 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
/* EINVAL=missing, which is fine since it's optional */
if (ret != -EINVAL)
dev_err(dev,
- "could not parse property nvidia,function\n");
+ "%pOF: could not parse property nvidia,function\n", np);
function = NULL;
}
@@ -134,8 +134,8 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
goto exit;
/* EINVAL=missing, which is fine since it's optional */
} else if (ret != -EINVAL) {
- dev_err(dev, "could not parse property %s\n",
- cfg_params[i].property);
+ dev_err(dev, "%pOF: could not parse property %s\n",
+ np, cfg_params[i].property);
}
}
@@ -146,7 +146,7 @@ static int tegra_pinctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev,
reserve++;
ret = of_property_count_strings(np, "nvidia,pins");
if (ret < 0) {
- dev_err(dev, "could not parse property nvidia,pins\n");
+ dev_err(dev, "%pOF: could not parse property nvidia,pins\n", np);
goto exit;
}
reserve *= ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: tegra: add OF node when logging OF parsing errors
2023-09-26 10:39 [PATCH] pinctrl: tegra: add OF node when logging OF parsing errors Luca Ceresoli
@ 2023-09-26 13:41 ` Thierry Reding
2023-09-27 8:55 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2023-09-26 13:41 UTC (permalink / raw)
To: Luca Ceresoli
Cc: linux-tegra, Linus Walleij, Jonathan Hunter, Andy Shevchenko,
Prathamesh Shete, Thierry Reding, linux-gpio, linux-kernel,
Thomas Petazzoni
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Tue, Sep 26, 2023 at 12:39:38PM +0200, Luca Ceresoli wrote:
> These errors are not quite clear without also logging they device tree node
> being parsed, especially when the pinmux node has lots of subnodes. Adding
> the node name helps a lot in finding the node that triggers the error.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: tegra: add OF node when logging OF parsing errors
2023-09-26 10:39 [PATCH] pinctrl: tegra: add OF node when logging OF parsing errors Luca Ceresoli
2023-09-26 13:41 ` Thierry Reding
@ 2023-09-27 8:55 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-09-27 8:55 UTC (permalink / raw)
To: Luca Ceresoli
Cc: linux-tegra, Thierry Reding, Jonathan Hunter, Andy Shevchenko,
Prathamesh Shete, Thierry Reding, linux-gpio, linux-kernel,
Thomas Petazzoni
On Tue, Sep 26, 2023 at 12:39 PM Luca Ceresoli
<luca.ceresoli@bootlin.com> wrote:
> These errors are not quite clear without also logging they device tree node
> being parsed, especially when the pinmux node has lots of subnodes. Adding
> the node name helps a lot in finding the node that triggers the error.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-27 8:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-26 10:39 [PATCH] pinctrl: tegra: add OF node when logging OF parsing errors Luca Ceresoli
2023-09-26 13:41 ` Thierry Reding
2023-09-27 8:55 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).